xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/3] xen/arm: Update early print console UART address for Broadcom 7445D0.
@ 2014-09-30 22:57 Jon Fraser
  2014-10-01 15:30 ` Julien Grall
  0 siblings, 1 reply; 5+ messages in thread
From: Jon Fraser @ 2014-09-30 22:57 UTC (permalink / raw)
  To: xen-devel; +Cc: Jon Fraser

The console UART address changed between chip versions C0 and D0.
Broadcom 7445[ABC]0 verions were not released and are not supported.

Signed-off-by: Jon Fraser <jfraser@broadcom.com>
---
 xen/arch/arm/Rules.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
index 26fafa2..d369b40 100644
--- a/xen/arch/arm/Rules.mk
+++ b/xen/arch/arm/Rules.mk
@@ -86,7 +86,7 @@ EARLY_UART_REG_SHIFT := 2
 endif
 ifeq ($(CONFIG_EARLY_PRINTK), brcm)
 EARLY_PRINTK_INC := 8250
-EARLY_UART_BASE_ADDRESS := 0xF0406B00
+EARLY_UART_BASE_ADDRESS := 0xF040AB00
 EARLY_UART_REG_SHIFT := 2
 endif
 ifeq ($(CONFIG_EARLY_PRINTK), xgene-storm)
-- 
1.9.0.138.g2de3478

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/3] xen/arm: Update early print console UART address for Broadcom 7445D0.
  2014-09-30 22:57 [PATCH 2/3] xen/arm: Update early print console UART address for Broadcom 7445D0 Jon Fraser
@ 2014-10-01 15:30 ` Julien Grall
  2014-10-01 15:31   ` Julien Grall
  0 siblings, 1 reply; 5+ messages in thread
From: Julien Grall @ 2014-10-01 15:30 UTC (permalink / raw)
  To: Jon Fraser, xen-devel, Ian Campbell, Stefano Stabellini,
	Tim Deegan

Hello Jon,

On 09/30/2014 11:57 PM, Jon Fraser wrote:
> The console UART address changed between chip versions C0 and D0.
> Broadcom 7445[ABC]0 verions were not released and are not supported.
> 
> Signed-off-by: Jon Fraser <jfraser@broadcom.com>
Reviewed-by: Julien Grall <julien.grall@linaro.org>

> ---
>  xen/arch/arm/Rules.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index 26fafa2..d369b40 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -86,7 +86,7 @@ EARLY_UART_REG_SHIFT := 2
>  endif
>  ifeq ($(CONFIG_EARLY_PRINTK), brcm)
>  EARLY_PRINTK_INC := 8250
> -EARLY_UART_BASE_ADDRESS := 0xF0406B00
> +EARLY_UART_BASE_ADDRESS := 0xF040AB00
>  EARLY_UART_REG_SHIFT := 2
>  endif
>  ifeq ($(CONFIG_EARLY_PRINTK), xgene-storm)
> 

Regards,

-- 
Julien Grall

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/3] xen/arm: Update early print console UART address for Broadcom 7445D0.
  2014-10-01 15:30 ` Julien Grall
@ 2014-10-01 15:31   ` Julien Grall
  2014-10-02 15:53     ` Julien Grall
  0 siblings, 1 reply; 5+ messages in thread
From: Julien Grall @ 2014-10-01 15:31 UTC (permalink / raw)
  To: Jon Fraser, xen-devel, Ian Campbell, Stefano Stabellini,
	Tim Deegan

On 10/01/2014 04:30 PM, Julien Grall wrote:
> Hello Jon,
> 
> On 09/30/2014 11:57 PM, Jon Fraser wrote:
>> The console UART address changed between chip versions C0 and D0.
>> Broadcom 7445[ABC]0 verions were not released and are not supported.

Hmmm... forgot about the NIT:

s/verions/versions/

>> Signed-off-by: Jon Fraser <jfraser@broadcom.com>
> Reviewed-by: Julien Grall <julien.grall@linaro.org>
> 
>> ---
>>  xen/arch/arm/Rules.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
>> index 26fafa2..d369b40 100644
>> --- a/xen/arch/arm/Rules.mk
>> +++ b/xen/arch/arm/Rules.mk
>> @@ -86,7 +86,7 @@ EARLY_UART_REG_SHIFT := 2
>>  endif
>>  ifeq ($(CONFIG_EARLY_PRINTK), brcm)
>>  EARLY_PRINTK_INC := 8250
>> -EARLY_UART_BASE_ADDRESS := 0xF0406B00
>> +EARLY_UART_BASE_ADDRESS := 0xF040AB00
>>  EARLY_UART_REG_SHIFT := 2
>>  endif
>>  ifeq ($(CONFIG_EARLY_PRINTK), xgene-storm)
>>
> 
> Regards,
> 


-- 
Julien Grall

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/3] xen/arm: Update early print console UART address for Broadcom 7445D0.
  2014-10-01 15:31   ` Julien Grall
@ 2014-10-02 15:53     ` Julien Grall
  2014-10-02 16:18       ` Jonathan Fraser
  0 siblings, 1 reply; 5+ messages in thread
From: Julien Grall @ 2014-10-02 15:53 UTC (permalink / raw)
  To: Jon Fraser, xen-devel, Ian Campbell, Stefano Stabellini,
	Tim Deegan

Hello Jon,

On 10/01/2014 04:31 PM, Julien Grall wrote:
> On 10/01/2014 04:30 PM, Julien Grall wrote:
>> Hello Jon,
>>
>> On 09/30/2014 11:57 PM, Jon Fraser wrote:
>>> The console UART address changed between chip versions C0 and D0.
>>> Broadcom 7445[ABC]0 verions were not released and are not supported.
> 
> Hmmm... forgot about the NIT:
> 
> s/verions/versions/

One last thing, sorry...

Could you update docs/misc/arm/early-printk.txt to add an entry for your
new board?

Thanks,

-- 
Julien Grall

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/3] xen/arm: Update early print console UART address for Broadcom 7445D0.
  2014-10-02 15:53     ` Julien Grall
@ 2014-10-02 16:18       ` Jonathan Fraser
  0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Fraser @ 2014-10-02 16:18 UTC (permalink / raw)
  To: Julien Grall
  Cc: Jonathan Fraser, Tim Deegan, Ian Campbell, Stefano Stabellini,
	xen-devel@lists.xen.org

On Thu, 2014-10-02 at 16:53 +0100, Julien Grall wrote:
> Hello Jon,
> 
> On 10/01/2014 04:31 PM, Julien Grall wrote:
> > On 10/01/2014 04:30 PM, Julien Grall wrote:
> >> Hello Jon,
> >>
> >> On 09/30/2014 11:57 PM, Jon Fraser wrote:
> >>> The console UART address changed between chip versions C0 and D0.
> >>> Broadcom 7445[ABC]0 verions were not released and are not supported.
> > 
> > Hmmm... forgot about the NIT:
> > 
> > s/verions/versions/
> 
> One last thing, sorry...
> 
> Could you update docs/misc/arm/early-printk.txt to add an entry for your
> new board?
> 
> Thanks,
> 

Sure.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-10-02 16:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-30 22:57 [PATCH 2/3] xen/arm: Update early print console UART address for Broadcom 7445D0 Jon Fraser
2014-10-01 15:30 ` Julien Grall
2014-10-01 15:31   ` Julien Grall
2014-10-02 15:53     ` Julien Grall
2014-10-02 16:18       ` Jonathan Fraser

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).