From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: julien.grall@linaro.org, xen-devel@lists.xen.org,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 1/2] xen/arm: Initial support for PSCI-0.2
Date: Thu, 2 Oct 2014 14:43:26 -0500 [thread overview]
Message-ID: <542DAADE.60808@amd.com> (raw)
In-Reply-To: <1412259679.17146.22.camel@citrix.com>
On 10/02/2014 09:21 AM, Ian Campbell wrote:
> On Wed, 2014-10-01 at 15:02 -0500, suravee.suthikulpanit@amd.com wrote:
>> -int __init psci_init(void)
>> +void call_psci_system_off(void)
>> +{
>> + if ( psci_ver > 2 )
>
> Doesn't this need to be >= to do anything on a 0.2 system? (Likewise in
> the fn below)
Ah yes. Thanks.
>
>> + __invoke_psci_fn_smc(PSCI_0_2_FN_SYSTEM_OFF, 0, 0, 0);
>
> Should we print a message in the case that we aren't able to call the
> 0.2 handler? (again, likewise below)
>
I feel that this will be too verbose for the PSCI-0.1 case since this
function always get called in the arch/arm/shutdown.c
Suravee
next prev parent reply other threads:[~2014-10-02 19:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 20:02 [PATCH 0/2] Introduce PSCI-0.2 supports suravee.suthikulpanit
2014-10-01 20:02 ` [PATCH 1/2] xen/arm: Initial support for PSCI-0.2 suravee.suthikulpanit
2014-10-02 9:07 ` Stefano Stabellini
2014-10-02 10:51 ` Julien Grall
2014-10-02 14:19 ` Ian Campbell
2014-10-02 20:17 ` Suravee Suthikulpanit
2014-10-02 14:21 ` Ian Campbell
2014-10-02 19:43 ` Suravee Suthikulpanit [this message]
2014-10-01 20:02 ` [PATCH 2/2] xen/arm: Use PSCI-0.2 for machine_halt/restart by default suravee.suthikulpanit
2014-10-02 9:04 ` Stefano Stabellini
2014-10-02 10:54 ` Julien Grall
2014-10-02 19:51 ` Suravee Suthikulpanit
2014-10-02 21:50 ` Julien Grall
2014-10-03 0:00 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542DAADE.60808@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=Ian.Campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).