From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH 2/2] xen/arm: Use PSCI-0.2 for machine_halt/restart by default Date: Thu, 2 Oct 2014 14:51:05 -0500 Message-ID: <542DACA9.5010000@amd.com> References: <1412193773-31042-1-git-send-email-suravee.suthikulpanit@amd.com> <1412193773-31042-3-git-send-email-suravee.suthikulpanit@amd.com> <542D2EF7.6040708@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <542D2EF7.6040708@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 10/02/2014 05:54 AM, Julien Grall wrote: > Hi Suravee, > > On 10/01/2014 09:02 PM, suravee.suthikulpanit@amd.com wrote: >> void machine_halt(void) >> { >> + int timeout = 10; >> + >> watchdog_disable(); >> console_start_sync(); >> local_irq_enable(); >> smp_call_function(halt_this_cpu, NULL, 0); >> + local_irq_disable(); >> + >> + /* Wait at most another 10ms for all other CPUs to go offline. */ >> + while ( (num_online_cpus() > 1) && (timeout-- > 0) ) >> + mdelay(1); >> + > > This doesn't look like PSCI specific. Can you explain in the commit > message why you need to add this new block of code? > > Regards, > It's not PSCI specific. I was just trying to handle the graceful shutdown similar to the code flow in machine_restart. If you think it's not necessary, I can take this out. Suravee