From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH 1/2] xen/arm: Initial support for PSCI-0.2 Date: Thu, 2 Oct 2014 15:17:59 -0500 Message-ID: <542DB2F7.8020005@amd.com> References: <1412193773-31042-1-git-send-email-suravee.suthikulpanit@amd.com> <1412193773-31042-2-git-send-email-suravee.suthikulpanit@amd.com> <542D2E40.2030806@linaro.org> <1412259583.17146.20.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1412259583.17146.20.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: xen-devel@lists.xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 10/02/2014 09:19 AM, Ian Campbell wrote: >>> +int __init psci_init(void) >>> > >+{ >>> > >+ const struct dt_device_node *psci; >>> > >+ >>> > >+ psci = dt_find_compatible_node(NULL, NULL, "arm,psci"); >>> > >+ if ( psci ) >>> > >+ return psci_init_0_1(psci); >>> > >+ >>> > >+ psci = dt_find_compatible_node(NULL, NULL, "arm,psci-0.2"); >>> > >+ if ( psci ) >>> > >+ return psci_init_0_2(psci); >>> > >+ >> > >> >I think we need to prefer PSCI 0.2 if the platform supports the both >> >version of PSCI. > Yes, please. > > This may require also falling back to 0.1 if psci_init_0_2 fails? > Good point. I just realized that DT could have: compatible = "arm,psci-0.2", "arm,psci" Suravee