Re: [PATCH] mini-os: enable compiler check for printk format types

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 08/10/14 12:12, Thomas Leonard wrote:
> On 6 October 2014 14:28, Ian Campbell <Ian.Campbell@citrix.com> wrote:
>> On Sun, 2014-10-05 at 21:30 +0200, Samuel Thibault wrote:
>>
>>>> Samuel, are you ok with the patch after those clarifications?
>>> Yes.
>> I interpreted this as an Acked-by, I hope that's ok, and was about to
>> commit when:
>> disk_read.c: In function 'vtpm_load_disk':
>> disk_read.c:539:59: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format]
>> disk_read.c:539:59: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format]
>> disk_read.c:540:2: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format]
>> disk_read.c:540:2: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format]
>> disk_read.c:542:30: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format]
>> disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format]
>> disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format]
>> disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format]
>> disk_read.c:545:47: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format]
>> disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format]
>> disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format]
>> disk_read.c:548:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Werror=format]
>> disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format]
>> disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format]
>> disk_read.c:551:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format]
>>
>> That's on an x86_32 stubdom build.
> What's the exact command I should use to test the builds? I did a
> "make build" in "stubdom" in an x86_32 container and it worked*, but I
> now see that doing "make" in the "stubdom/vtpmmgr" subdirectory gives
> the above error.


make XEN_TARGET_ARCH=x86_32 <mumble>

>
> * (after adding some symlinks to fix "xen-config-host.h:19:21: fatal
> error: xenctrl.h: No such file or directory" error in "ioemu")

You need to refresh your underlying qemu-trad repository (`make -C tools
subtree-force-update` ought to work).  The header files moved, requiring
a synchronised update to both repositories.


~Andrew