From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hongyang Yang Subject: Re: Coverity complaints about Remus in xen-unstable Date: Mon, 20 Oct 2014 20:08:45 +0800 Message-ID: <5444FB4D.6060203@cn.fujitsu.com> References: <542bcdb5e7156_555012573206153a@scan.coverity.com.mail> <21548.7820.533849.721113@mariner.uk.xensource.com> <542C2D2E.3060007@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XgBmg-0000pW-J2 for xen-devel@lists.xenproject.org; Mon, 20 Oct 2014 12:09:58 +0000 In-Reply-To: <542C2D2E.3060007@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Ian Jackson Cc: Shriram Rajagopalan , xen-devel@lists.xenproject.org, coverity@xenproject.org, Lai Jiangshan , Wen Congyang List-Id: xen-devel@lists.xenproject.org SGkgSWFuSiwgQW5kcmV3LAoKICAgU29ycnkgZm9yIHRoZSBsYXRlIHJlcGxheSwganVzdCBiYWNr IGZyb20gYSB2YWNhdGlvbi4KCuWcqCAxMC8wMi8yMDE0IDEyOjM0IEFNLCBBbmRyZXcgQ29vcGVy IOWGmemBkzoKPiBPbiAwMS8xMC8xNCAxNjozMiwgSWFuIEphY2tzb24gd3JvdGU6Cj4+IHNjYW4t YWRtaW5AY292ZXJpdHkuY29tIHdyaXRlcyAoIk5ldyBEZWZlY3RzIHJlcG9ydGVkIGJ5IENvdmVy aXR5IFNjYW4gZm9yIFhlblByb2plY3QiKToKPj4+IFBsZWFzZSBmaW5kIHRoZSBsYXRlc3QgcmVw b3J0IG9uIG5ldyBkZWZlY3QocykgaW50cm9kdWNlZCB0byBYZW5Qcm9qZWN0IGZvdW5kIHdpdGgg Q292ZXJpdHkgU2Nhbi4KPj4gLi4uCj4+PiAqKiBDSUQgMTI0MjMyMDogIFVuaW5pdGlhbGl6ZWQg c2NhbGFyIHZhcmlhYmxlICAoVU5JTklUKQo+Pj4gL3Rvb2xzL2xpYnhsL2xpYnhsLmM6IDg1OSBp biBsaWJ4bF9kb21haW5fcmVtdXNfc3RhcnQoKQo+PiBUaGlzIGlzIGEgZmFpbHVyZSB0byBzZXQg cmMgb24gc29tZSBvZiB0aGUgZXJyb3IgcGF0aHMuICBJdCBpcyBub3QgYQo+PiBiaWcgcHJvYmxl bSwgYnV0IGl0IGlzIGEgYnVnIHdoaWNoIHNob3VsZCBiZSBmaXhlZCwgaW4KPj4gbGlieGxfZG9t YWluX3JlbXVzX3N0YXJ0Lgo+Pgo+PiBZYW5nIEhvbmd5YW5nLCBjb3VsZCB5b3UgcHJlcGFyZSBh IHBhdGNoIHRvIGZpeCBhbGwgdGhlIGVycm9yIGV4aXQKPj4gcGF0aHMgZnJvbSB0aGlzIGZ1bmN0 aW9uIHRvIGNvcnJlY3RseSBzZXQgcmMgPyAgVGhhbmtzLgo+Cj4gTm8gbmVlZCAtIEkgYWxyZWFk eSBkaWQgYSBwYXRjaCBlYXJsaWVyIHRvZGF5LCB3aGljaCBoYXMgZXZlbiBiZWVuCj4gY29tbWl0 dGVkLgo+Cj4gaHR0cDovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPWNvbW1p dGRpZmY7aD1iYzhlMjA0MTRhZWFjZGIyM2QxODM3OTNjMWQ5NDdlMjhjMjY2ODViCgpUaGFuayB5 b3UgZm9yIHRoaXMuCgo+Cj4+Cj4+Cj4+IFRoZW4gdGhlcmUgYXJlIGFsc28gYSBsb3QgbGlrZSB0 aGlzOgo+Pgo+Pj4gKiogQ0lEIDEyNDIzMjE6ICBVbnVzZWQgdmFsdWUgIChVTlVTRURfVkFMVUUp Cj4+PiAvdG9vbHMvbGlieGwvbGlieGxfcmVtdXNfZGV2aWNlLmM6IDIxNiBpbiBhbGxfZGV2aWNl c19zZXR1cF9jYigpCj4+IFRoZXNlIGFyZSBhbGw6Cj4+Cj4+Pj4+PiAgICAgIFBvaW50ZXIgImdj IiByZXR1cm5lZCBieSAibGlieGxfX2FvX2lucHJvZ3Jlc3NfZ2MoYW8pIiBpcyBuZXZlciB1c2Vk Lgo+PiBUaGlzIGlzIGJlY2F1c2UgYSBsb3Qgb2YgZnVuY3Rpb25zIHdlcmUgaW50cm9kdWNlZCB3 aGljaCBzYXkKPj4gICAgICBTVEFURV9BT19HQyhzb21ldGhpbmcpCj4+IGJ1dCBkbyBub3QgaGFw cGVuIHRvIHVzZSB0aGUgZ2MuICBUaGlzIGlzIGFjdHVhbGx5IHBlcmZlY3RseSBub3JtYWwKPj4g aW4gbGlieGwuICBBbmQgdGhlIFNUQVRFX0FPX0dDIG1hY3JvIHNheXM6Cj4+ICAgICAgbGlieGxf X2djICpjb25zdCBnYyBfX2F0dHJpYnV0ZV9fKCh1bnVzZWQpKSA9IGxpYnhsX19hb19pbnByb2dy ZXNzX2djKGFvKQo+PiBTbyBJIHRoaW5rIHRoaXMgaXMgc29tZSBraW5kIG9mIGZhaWx1cmUgYnkg Q292ZXJpdHkuCj4KPiBUaGlzIGlzIG5vdCBhIGZhaWx1cmUgaW4gdGhlIHNsaWdodGVzdC4gIFRo ZSBzdGF0ZW1lbnQgaXMgIllvdSBoYXZlIGFuCj4gdW51c2VkIHZhcmlhYmxlLCBhbmQgdGhpcyBj b25zdGl0dXRlcyBhIHBvdGVudGlhbCBjb2RlIG1haW50ZW5hbmNlCj4gcHJvYmxlbSB3aGljaCB5 b3UgbWlnaHQgd2FudCB0byBzZWUgYWJvdXQgZml4aW5nIi4KPgo+IENvdmVyaXR5IGNvdmVycyBj b2RpbmcgYmVzdCBwcmFjdGljZSBhcyB3ZWxsIGFzIGJ1Z3MuICBUaGUgZmFjdCB0aGF0IHRoZQo+ IHByb2dyYW1tZXIgaGFzIGluZGljYXRlZCB0aGF0IHRoZSB2YWx1ZSBpcyB1bnVzZWQgZG9lcyBu b3QgaW52YWxpZGF0ZQo+IENvdmVyaXRpZXMgc3RhdGVtZW50IGFib3V0IGl0IGJlaW5nIHVudXNl ZC4KPgo+IEFsc28gYmVhciBpbiBtaW5kIHRoYXQgQ292ZXJpdGllcyBlbnRpcmUgcHVycG9zZSBp cyB0byBzZWNvbmQtZ3Vlc3Mgd2hhdAo+IHRoZSBwcm9ncmFtbWVyIGhhcyBhY3R1YWxseSB3cml0 dGVuLCBhbmQgcmFpc2UgcXVlcmllcyBiYXNlZCBvbiB3aGF0Cj4gdGhleSBwbGF1c2libHkgbWF5 IGhhdmUgb3Zlcmxvb2tlZC4gIEJsaW5kbHkgdHJ1c3RpbmcgYW4KPiAiX19hdHRyaWJ1dGVfXygo dW51c2VkKSkiIHRvICdmaXgnIGEgY29tcGlsZXIgd2FybmluZyB3b3VsZCBlbnRpcmVseQo+IGRl ZmVhdCB0aGUgcHVycG9zZSBmbGFnZ2luZyBjb2RlIG1haW50ZW5hbmNlIGlzc3Vlcy4KPgo+Cj4+ Cj4+IFdlaXJkbHksIGFsdGhvdWdoIG1hbnkgb2YgdGhlc2UgdXNlcyAoZWcsIGFsbF9kZXZpY2Vz X3NldHVwX2NiIGF0Cj4+IGxpYnhsX3JlbXVzX2RldmljZS5jOjIxMikgYXJlIGluIGZ1bmN0aW9u cyB3aGljaCBkbyBub3QgdXNlIHRoZQo+PiBkZWZpbmVkIGBhbycgdmFyaWFibGUgZWl0aGVyLCBh bmQgYW8gaXMgX25vdF8gbWFya2VkIG9rLXRvLWJlLXVudXNlZCwKPj4gQ292ZXJpdHkgaGFzbid0 IGNvbXBsYWluZWQgYWJvdXQgdGhhdC4KPj4KPj4gQW5kcmV3IENvb3BlciwgYXMgb3VyIENvdmVy aXR5IG1vZGVsbGluZyBleHBlcnQsIGNhbiB5b3UgY29tbWVudCA/Cj4KPiAnYW8nIGlzIHVuY29u ZGl0aW9uYWxseSB1c2VkIGluIGFsbCBwbGFjZXMsIGFzIGEgcGFyYW1ldGVyIHRvCj4gbGlieGxf X2FvX2lucHJvZ3Jlc3NfZ2MoKSwgdXNlZCB0byBnZXQgdGhlIGdjLgo+Cj4+Cj4+Cj4+IEkgZG9u J3QgdGhpbmsgdGhlcmUgaXMgYWN0dWFsbHkgYW55dGhpbmcgd3Jvbmcgd2l0aCBoYXZpbmcgU1RB VEVfQU9fR0MKPj4gdXNlZCB3aGVuIG5vdCBuZWVkZWQuICBJdCB3aWxsIHJlZHVjZSBub2lzZSBp biBmdXR1cmUgaWYgY29kZSBpcyBhZGRlZAo+PiB3aGljaCBuZWVkcyBpdCwgYW5kIGluIHRoZSBt ZWFudGltZSBpdCdzIGhhcm1sZXNzLiAgU28gSSB0aGluayBpdAo+PiB3b3VsZCBwcm9iYWJseSBi ZSBiZXR0ZXIgaWYgU1RBVEVfQU9fR0MgZGVjbGFyZWQgYW8KPj4gX19hdHRyaWJ1dGVfXygodW51 c2VkKSkgYXMgd2VsbC4KPgo+IEkgZGlzYWdyZWUuICBSZW1vdmluZyB0aGUgZ2MgY291bGQgYWxz byBhbGVpdmF0ZSByZWR1bmRhbnQgY2FsbHMgdG8KPiBsaWJ4bF9fYW9faW5wcm9ncmVzc19nYygp IHdoaWNoIGlzIG5vdCBpbmxpbmFibGUgYXMgaXQgcmVzaWRlcyBpbiBhCj4gZGlmZmVyZW50IHRy YW5zbGF0aW9uIHVuaXQuCj4KPiB+QW5kcmV3Cj4KPiAuCj4KCi0tIApUaGFua3MsCllhbmcuCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwg bWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3Jn L3hlbi1kZXZlbAo=