From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH ARM v8 2/4] mini-os: arm: interrupt controller Date: Tue, 21 Oct 2014 16:22:40 +0100 Message-ID: <54467A40.4090201@linaro.org> References: <1412328051-20015-1-git-send-email-talex5@gmail.com> <1412328051-20015-3-git-send-email-talex5@gmail.com> <1413889218.23337.24.camel@citrix.com> <54466D06.5070000@linaro.org> <1413904601.23337.50.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XgbGr-0003qP-BI for xen-devel@lists.xenproject.org; Tue, 21 Oct 2014 15:22:49 +0000 Received: by mail-wg0-f45.google.com with SMTP id m15so1695356wgh.16 for ; Tue, 21 Oct 2014 08:22:48 -0700 (PDT) In-Reply-To: <1413904601.23337.50.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Thomas Leonard , Dave.Scott@eu.citrix.com, anil@recoil.org, stefano.stabellini@eu.citrix.com, xen-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org List-Id: xen-devel@lists.xenproject.org On 10/21/2014 04:16 PM, Ian Campbell wrote: > On Tue, 2014-10-21 at 15:26 +0100, Julien Grall wrote: >> Our implementation of ITARGETSR doesn't handle correctly read/write per >> byte. If the register is RO (such as for the SGIs and PPIs), our write >> ignore is checking that the guest is writing a word. > > That's a bug. Agree >> Even though we need to fix it in Xen (I could send a patch for it). We >> need to keep this implementation if we want mini-os to run on Xen 4.4.x. > > We should fix bugs, not workaround them in the guest. Writing a 32 bits value into those registers is perfectly value and not a workaround. In this case, it would make mini-os working directly on Xen 4.4. -- Julien Grall