From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH V2 for-4.5] EFI: Always use EFI command line Date: Sat, 25 Oct 2014 18:22:16 +0800 Message-ID: <544B79D8.8090702@linaro.org> References: <1414194069-24690-1-git-send-email-roy.franz@linaro.org> <1414227980.3584.15.camel@citrix.com> <544B6CE7.5010905@linaro.org> Reply-To: Fu Wei Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <544B6CE7.5010905@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Roy Franz , leif Lindholm Cc: tim@xen.org, stefano.stabellini@citrix.com, jbeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 10/25/2014 05:27 PM, Fu Wei wrote: > On 10/25/2014 05:06 PM, Ian Campbell wrote: >> On Fri, 2014-10-24 at 16:41 -0700, Roy Franz wrote: >>> (I'm not sure how I'm supposed to refer to to docs/misc/efi.markdown in >>> the booting.txt. Should I assume that it will be processed to html >>> and refrence it that way?) >> >> This stuff kinda sucks because it all depends on where you build and >> install to etc. What you've done in naming the file as it appears in the >> source is fine. Other places use a reference to the canonical online >> copy at http://xenbits.xen.org/docs/unstable/ which is fine too I think. >> >>> @@ -104,4 +106,6 @@ and really not meant to be used together with the `-cfg=` command line option. >>> Filenames must be specified relative to the location of the EFI binary. >>> >>> Extra options to be passed to Xen can also be specified on the command line, >>> -following a `--` separator option. >>> +following a `--` separator option. >> >> Will grub automatically insert this "--" marker? Or is there some >> special handling in Xen when none of -cfg/-help/-videothing are present? >> (Doesn't look to be the case) > > For now, I didn't make this automatically "--" injection. > > Do we need to do this, or just let user do it by themselves? > > In my opinion, according to the wiki page, we should make the injection? > http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot > > any thought and suggestion?? :-) I have made a patch for this: If the first argument is not "--", grub will add "--" as first argument. But I don't think it is a good fix. So please let me know what is your decision, then I can make the multiboot behavior right :-) before I get your info, my multiboot patch won't take care of "--" > >> >> Ian. >> > > -- Best regards, Fu Wei Software Engineer From Red Hat LEG Team Linaro.org | Open source software for ARM SoCs Ph: +86 186 2020 4684 (mobile) IRC: fuwei Skype: tekkamanninja Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021