From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v7][RFC][PATCH 01/13] introduce
	XENMEM_reserved_device_memory_map
Date: Mon, 27 Oct 2014 10:11:17 +0800
Message-ID: <544DA9C5.90506@intel.com>
References: <1414136077-18599-1-git-send-email-tiejun.chen@intel.com>
	<1414136077-18599-2-git-send-email-tiejun.chen@intel.com>
	<544A7A150200007800041FAC@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <544A7A150200007800041FAC@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 2014/10/24 22:11, Jan Beulich wrote:
>>>> On 24.10.14 at 09:34, <tiejun.chen@intel.com> wrote:
>> From: Jan Beulich <jbeulich@suse.com>
>>
>> This is a prerequisite for punching holes into HVM and PVH guests' P2M
>> to allow passing through devices that are associated with (on VT-d)
>> RMRRs.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
>
> I'm confused - you dropped Kevins ack and instead added you S-o-b

I need to add this ACK.

> despite you not having changed anything in the patch.

The original you sent to me previously is needed to rebase on the 
latest. Please check xen/include/public/memory.h.

The original:

--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -573,7 +573,29 @@ struct vnuma_topology_info {
  typedef struct vnuma_topology_info vnuma_topology_info_t;
  DEFINE_XEN_GUEST_HANDLE(vnuma_topology_info_t);

-/* Next available subop number is 27 */

Mine:

--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -523,7 +523,29 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_sharing_

  #endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */

-/* Next available subop number is 26 */

Unless you're saying this kind of rebase shouldn't introduce my SOB.

>
> That said - in my local version I did a little bit of renaming. I'm
> attaching the most recent version for your reference.

I will pick this to try.

Thanks
Tiejun