From: Simon Rowe <simon.rowe@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: Dave Scott <Dave.Scott@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Stefano Stabellini <Stefano.Stabellini@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Simon Rowe <Simon.Rowe@citrix.com>
Subject: Re: [PATCH] pygrub: fix non-interactive parsing of grub1 config files
Date: Mon, 27 Oct 2014 12:51:02 +0000 [thread overview]
Message-ID: <544E3FB6.5010006@eu.citrix.com> (raw)
In-Reply-To: <20141024211526.GA23155@andromeda.dapyr.net>
On 24/10/14 22:15, Konrad Rzeszutek Wilk wrote:
> On Wed, Sep 10, 2014 at 12:50:29PM +0000, Dave Scott wrote:
>>
>> Redefining ?sel? from an index into an array into to a key of a dictionary sounds plausible to me? but I?m not really familiar enough with pygrub to offer a trustworthy opinion.
>>
>> I?ve cc:d Simon Rowe who is more familiar with pygrub ? he may have some useful thoughts.
>>
> ping ?
>
I think this changeset could just cause a ValueError to be thrown if a
label was in cf.default at this point. I've got a patch I'm dev testing,
I'll post it shortly,
Simon
next prev parent reply other threads:[~2014-10-27 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 14:01 [PATCH] pygrub: fix non-interactive parsing of grub1 config files David Scott
2014-09-08 17:11 ` Boris Ostrovsky
2014-09-10 12:50 ` Dave Scott
2014-10-24 21:15 ` Konrad Rzeszutek Wilk
2014-10-27 12:51 ` Simon Rowe [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-27 16:00 Simon Rowe
2014-10-27 16:35 ` Boris Ostrovsky
2014-11-04 10:46 ` Ian Campbell
2014-11-04 15:26 ` Konrad Rzeszutek Wilk
2014-10-28 12:38 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E3FB6.5010006@eu.citrix.com \
--to=simon.rowe@eu.citrix.com \
--cc=Dave.Scott@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=Simon.Rowe@citrix.com \
--cc=Stefano.Stabellini@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad@darnok.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).