From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Rowe Subject: Re: [PATCH] pygrub: fix non-interactive parsing of grub1 config files Date: Mon, 27 Oct 2014 12:51:02 +0000 Message-ID: <544E3FB6.5010006@eu.citrix.com> References: <1410184885-27359-1-git-send-email-dave.scott@citrix.com> <540DE355.2070309@oracle.com> <7DA4B952-036B-4638-A411-93F269320402@citrix.com> <20141024211526.GA23155@andromeda.dapyr.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XijlN-0002IK-OK for xen-devel@lists.xenproject.org; Mon, 27 Oct 2014 12:51:09 +0000 In-Reply-To: <20141024211526.GA23155@andromeda.dapyr.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Dave Scott , Ian Campbell , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Ian Jackson , Boris Ostrovsky , Simon Rowe List-Id: xen-devel@lists.xenproject.org On 24/10/14 22:15, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 10, 2014 at 12:50:29PM +0000, Dave Scott wrote: >> >> Redefining ?sel? from an index into an array into to a key of a dictionary sounds plausible to me? but I?m not really familiar enough with pygrub to offer a trustworthy opinion. >> >> I?ve cc:d Simon Rowe who is more familiar with pygrub ? he may have some useful thoughts. >> > ping ? > I think this changeset could just cause a ValueError to be thrown if a label was in cf.default at this point. I've got a patch I'm dev testing, I'll post it shortly, Simon