From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v7][RFC][PATCH 01/13] introduce
	XENMEM_reserved_device_memory_map
Date: Tue, 28 Oct 2014 10:35:51 +0800
Message-ID: <544F0107.7070008@intel.com>
References: <1414136077-18599-1-git-send-email-tiejun.chen@intel.com>
	<1414136077-18599-2-git-send-email-tiejun.chen@intel.com>
	<544E4A1F.9000804@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <544E4A1F.9000804@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>, JBeulich@suse.com, tim@xen.org, konrad.wilk@oracle.com, kevin.tian@intel.com, yang.z.zhang@intel.com
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 2014/10/27 21:35, Julien Grall wrote:
> Hi,
>
> On 10/24/2014 08:34 AM, Tiejun Chen wrote:
>> diff --git a/xen/common/memory.c b/xen/common/memory.c
>> index cc36e39..51a32a8 100644
>> --- a/xen/common/memory.c
>> +++ b/xen/common/memory.c
>> @@ -692,6 +692,32 @@ out:
>>       return rc;
>>   }
>>
>> +struct get_reserved_device_memory {
>> +    struct xen_mem_reserved_device_memory_map map;
>> +    unsigned int used_entries;
>> +};
>> +
>> +static int get_reserved_device_memory(xen_pfn_t start,
>> +                                      xen_ulong_t nr, void *ctxt)
>
> This function is only used when HAS_PASSTHROUGH is defined. You have to
> protected by an #ifdef HAS_PASSTHROUGH.
>

I guess you mean we need to do this,

diff --git a/xen/common/memory.c b/xen/common/memory.c
index 1449c10..2177c56 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -692,6 +692,7 @@ out:
      return rc;
  }

+#ifdef HAS_PASSTHROUGH
  struct get_reserved_device_memory {
      struct xen_reserved_device_memory_map map;
      unsigned int used_entries;
@@ -717,6 +718,7 @@ static int get_reserved_device_memory(xen_pfn_t start,

      return 0;
  }
+#endif

  long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
  {

Jan,

With this above change, is the following working for you?

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Kevin Tian <kevin.tian@intel.com>
CC: Julien Grall <julien.grall@linaro.org>
[Julien: Protect some definitions by an #ifdef HAS_PASSTHROUGH.]
Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>

Thanks
Tiejun