From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian.Campbell@eu.citrix.com, Ian.Jackson@eu.citrix.com,
xen-devel@lists.xen.org, wei.liu2@citrix.com,
stefano.stabellini@eu.citrix.com
Subject: Re: [v2][PATCH] tools/hvmloader: link errno.h from xen internal
Date: Mon, 03 Nov 2014 18:05:38 +0800 [thread overview]
Message-ID: <54575372.7020406@intel.com> (raw)
In-Reply-To: <54575C3E020000780004440F@mail.emea.novell.com>
On 2014/11/3 17:43, Jan Beulich wrote:
>>>> On 03.11.14 at 10:00, <tiejun.chen@intel.com> wrote:
>> --- a/tools/firmware/hvmloader/Makefile
>> +++ b/tools/firmware/hvmloader/Makefile
>> @@ -84,9 +84,12 @@ ROMS += $(SEABIOS_ROM)
>> endif
>>
>> .PHONY: all
>> -all: subdirs-all
>> +all: subdirs-all .dir
>
> Considering uses going forward, I think subdirs-all should depend on
> .dir (which is being misnamed anyway, presumably due to blindly
> taking what is in tools/include/Makefile, where a directory _is_ being
> created). Considering that it's an individual file, the file name would
You're right.
> seem quite right to be used as dependency here.
So what about this?
.PHONY: all
all: subdirs-all errno
$(MAKE) hvmloader
errno:
ln -sf $(XEN_ROOT)/xen/include/xen/errno.h .
Thanks
Tiejun
next prev parent reply other threads:[~2014-11-03 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 9:00 [v2][PATCH] tools/hvmloader: link errno.h from xen internal Tiejun Chen
2014-11-03 9:43 ` Jan Beulich
2014-11-03 10:05 ` Chen, Tiejun [this message]
2014-11-03 10:19 ` Jan Beulich
2014-11-03 11:22 ` Chen, Tiejun
2014-11-03 11:37 ` Jan Beulich
2014-11-03 11:47 ` Chen, Tiejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54575372.7020406@intel.com \
--to=tiejun.chen@intel.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).