From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v2][PATCH] tools/hvmloader: link errno.h from xen internal Date: Mon, 03 Nov 2014 18:05:38 +0800 Message-ID: <54575372.7020406@intel.com> References: <1415005248-25620-1-git-send-email-tiejun.chen@intel.com> <54575C3E020000780004440F@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54575C3E020000780004440F@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian.Campbell@eu.citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 2014/11/3 17:43, Jan Beulich wrote: >>>> On 03.11.14 at 10:00, wrote: >> --- a/tools/firmware/hvmloader/Makefile >> +++ b/tools/firmware/hvmloader/Makefile >> @@ -84,9 +84,12 @@ ROMS += $(SEABIOS_ROM) >> endif >> >> .PHONY: all >> -all: subdirs-all >> +all: subdirs-all .dir > > Considering uses going forward, I think subdirs-all should depend on > .dir (which is being misnamed anyway, presumably due to blindly > taking what is in tools/include/Makefile, where a directory _is_ being > created). Considering that it's an individual file, the file name would You're right. > seem quite right to be used as dependency here. So what about this? .PHONY: all all: subdirs-all errno $(MAKE) hvmloader errno: ln -sf $(XEN_ROOT)/xen/include/xen/errno.h . Thanks Tiejun