From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v2][PATCH] tools/hvmloader: link errno.h from xen
	internal
Date: Mon, 03 Nov 2014 19:22:22 +0800
Message-ID: <5457656E.9040604@intel.com>
References: <1415005248-25620-1-git-send-email-tiejun.chen@intel.com>
	<54575C3E020000780004440F@mail.emea.novell.com>
	<54575372.7020406@intel.com>
	<545764D102000078000444F0@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <545764D102000078000444F0@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian.Campbell@eu.citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 2014/11/3 18:19, Jan Beulich wrote:
>>>> On 03.11.14 at 11:05, <tiejun.chen@intel.com> wrote:
>> On 2014/11/3 17:43, Jan Beulich wrote:
>>>>>> On 03.11.14 at 10:00, <tiejun.chen@intel.com> wrote:
>>>> --- a/tools/firmware/hvmloader/Makefile
>>>> +++ b/tools/firmware/hvmloader/Makefile
>>>> @@ -84,9 +84,12 @@ ROMS += $(SEABIOS_ROM)
>>>>    endif
>>>>
>>>>    .PHONY: all
>>>> -all: subdirs-all
>>>> +all: subdirs-all .dir
>>>
>>> Considering uses going forward, I think subdirs-all should depend on
>>> .dir (which is being misnamed anyway, presumably due to blindly
>>> taking what is in tools/include/Makefile, where a directory _is_ being
>>> created). Considering that it's an individual file, the file name would
>>
>> You're right.
>>
>>> seem quite right to be used as dependency here.
>>
>> So what about this?
>>
>> .PHONY: all
>> all: subdirs-all errno
>>       $(MAKE) hvmloader
>>
>> errno:
>>       ln -sf $(XEN_ROOT)/xen/include/xen/errno.h .
>
> This addresses just one of the points I made.

Are you saying that dependency?

@@ -87,6 +87,11 @@ endif
  all: subdirs-all
         $(MAKE) hvmloader

+subdirs-all: errno
+
+errno:
+       ln -sf $(XEN_ROOT)/xen/include/xen/errno.h .
+
  ovmf.o rombios.o seabios.o hvmloader.o: roms.inc
  smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(shell date +%m/%d/%Y)\""

Thanks
Tiejun