xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian.Campbell@eu.citrix.com, Ian.Jackson@eu.citrix.com,
	xen-devel@lists.xen.org, wei.liu2@citrix.com,
	stefano.stabellini@eu.citrix.com
Subject: Re: [v2][PATCH] tools/hvmloader: link errno.h from xen internal
Date: Mon, 03 Nov 2014 19:47:53 +0800	[thread overview]
Message-ID: <54576B69.2060705@intel.com> (raw)
In-Reply-To: <5457770102000078000445A5@mail.emea.novell.com>

On 2014/11/3 19:37, Jan Beulich wrote:
>>>> On 03.11.14 at 12:22, <tiejun.chen@intel.com> wrote:
>> Are you saying that dependency?
>>
>> @@ -87,6 +87,11 @@ endif
>>    all: subdirs-all
>>           $(MAKE) hvmloader
>>
>> +subdirs-all: errno
>> +
>> +errno:
>> +       ln -sf $(XEN_ROOT)/xen/include/xen/errno.h .
>> +
>>    ovmf.o rombios.o seabios.o hvmloader.o: roms.inc
>>    smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(shell date +%m/%d/%Y)\""
>
> Another step in the right direction. If now you also change the target
> to be "errno.h" instead of "errno", we'll have what we want.
>

Okay,

  all: subdirs-all
         $(MAKE) hvmloader

+subdirs-all: errno.h
+
+errno.h:
+       ln -sf $(XEN_ROOT)/xen/include/xen/errno.h .
+
  ovmf.o rombios.o seabios.o hvmloader.o: roms.inc
  smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(shell date +%m/%d/%Y)\""

If this is fine I will send next revision once some tools maintainer can 
give an acknowledge.

Thanks
Tiejun

      reply	other threads:[~2014-11-03 11:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03  9:00 [v2][PATCH] tools/hvmloader: link errno.h from xen internal Tiejun Chen
2014-11-03  9:43 ` Jan Beulich
2014-11-03 10:05   ` Chen, Tiejun
2014-11-03 10:19     ` Jan Beulich
2014-11-03 11:22       ` Chen, Tiejun
2014-11-03 11:37         ` Jan Beulich
2014-11-03 11:47           ` Chen, Tiejun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54576B69.2060705@intel.com \
    --to=tiejun.chen@intel.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).