Re: [PATCH] tools: remove blktap1

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 04/11/14 17:32, Konrad Rzeszutek Wilk wrote:
> On Tue, Nov 04, 2014 at 11:52:47AM +0000, Ian Campbell wrote:
>> This was disabled by default in Xen 4.4. Since xend has now been removed from
>> the tree I don't believe anything is using it.
> What about XenServer?

We are most definitely not using it, and haven’t used it in a very long
time. We explicitly nuke BLKTAP1 and BLKTAP2 from the Xen build.

>
> And isn't there some blktap3 ?

https://github.com/xapi-project/blktap

>
>> We need to pass an explicit CONFIG_BLKTAP1=n to qemu-xen-traditional otherwise
>> it defaults to y and doesn't build.
>>
>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> ---
>> I think this has probably missed the boat for 4.5 and there isn't much harm in
>> waiting for 4.6. I'm open to being told otherwise though ;-)
> You really want to be at the top of the commit list with the most deleted
> code, eh?

/me suspects that he is already, but I for one am a fan of pruning dead
code.

~Andrew