From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] tools: remove blktap1 Date: Tue, 4 Nov 2014 18:07:19 +0000 Message-ID: <545915D7.2070804@citrix.com> References: <1415101967-9844-1-git-send-email-ian.campbell@citrix.com> <20141104173228.GM4510@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20141104173228.GM4510@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk , Ian Campbell Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/11/14 17:32, Konrad Rzeszutek Wilk wrote: > On Tue, Nov 04, 2014 at 11:52:47AM +0000, Ian Campbell wrote: >> This was disabled by default in Xen 4.4. Since xend has now been removed= from >> the tree I don't believe anything is using it. > What about XenServer? We are most definitely not using it, and haven=92t used it in a very long time. We explicitly nuke BLKTAP1 and BLKTAP2 from the Xen build. > > And isn't there some blktap3 ? https://github.com/xapi-project/blktap > >> We need to pass an explicit CONFIG_BLKTAP1=3Dn to qemu-xen-traditional o= therwise >> it defaults to y and doesn't build. >> >> Signed-off-by: Ian Campbell >> Cc: Konrad Rzeszutek Wilk >> --- >> I think this has probably missed the boat for 4.5 and there isn't much h= arm in >> waiting for 4.6. I'm open to being told otherwise though ;-) > You really want to be at the top of the commit list with the most deleted > code, eh? /me suspects that he is already, but I for one am a fan of pruning dead code. ~Andrew