From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
yanghy@cn.fujitsu.com, guijianfeng@cn.fujitsu.com
Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: Is: Discussion about doing it in Xen 4.5 or Xen 4.6 Was:Re: [PATCH] tools: remove blktap1
Date: Tue, 4 Nov 2014 18:45:12 +0000 [thread overview]
Message-ID: <54591EB8.4070007@citrix.com> (raw)
In-Reply-To: <20141104184209.GT4510@laptop.dumpdata.com>
On 04/11/14 18:42, Konrad Rzeszutek Wilk wrote:
> On Tue, Nov 04, 2014 at 06:07:19PM +0000, Andrew Cooper wrote:
>> On 04/11/14 17:32, Konrad Rzeszutek Wilk wrote:
>>> On Tue, Nov 04, 2014 at 11:52:47AM +0000, Ian Campbell wrote:
>>>> This was disabled by default in Xen 4.4. Since xend has now been removed from
>>>> the tree I don't believe anything is using it.
>>> What about XenServer?
>> We are most definitely not using it, and haven’t used it in a very long
>> time. We explicitly nuke BLKTAP1 and BLKTAP2 from the Xen build.
>>
>>> And isn't there some blktap3 ?
>> https://github.com/xapi-project/blktap
>>
>>>> We need to pass an explicit CONFIG_BLKTAP1=n to qemu-xen-traditional otherwise
>>>> it defaults to y and doesn't build.
>>>>
>>>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>> ---
>>>> I think this has probably missed the boat for 4.5 and there isn't much harm in
>>>> waiting for 4.6. I'm open to being told otherwise though ;-)
>>> You really want to be at the top of the commit list with the most deleted
>>> code, eh?
>> /me suspects that he is already, but I for one am a fan of pruning dead
>> code.
> True, but we did talk about xend removal for quite a while before doing it.
>
> However, I believe that the folks that did Remus look to be using it
> (And they have tons of patches against it).
>
>
> It is unclear to me whether they:
> - want to be the maintainers of it?
> - want to use blktap3 but haven't yet backported their patches.
The remus patches are against blktap2, not blktap1. We currently have
both in-tree.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-11-04 18:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 11:52 [PATCH] tools: remove blktap1 Ian Campbell
2014-11-04 11:54 ` Ian Campbell
2014-11-04 13:33 ` David Vrabel
2014-11-04 17:32 ` Konrad Rzeszutek Wilk
2014-11-04 18:07 ` Andrew Cooper
2014-11-04 18:42 ` Is: Discussion about doing it in Xen 4.5 or Xen 4.6 Was:Re: " Konrad Rzeszutek Wilk
2014-11-04 18:45 ` Andrew Cooper [this message]
2014-11-04 20:00 ` Konrad Rzeszutek Wilk
2014-11-05 9:20 ` Ian Campbell
2014-11-05 18:16 ` Konrad Rzeszutek Wilk
2014-11-05 18:21 ` George Dunlap
2014-11-12 15:47 ` Shriram Rajagopalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54591EB8.4070007@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).