From: rshriram@cs.ubc.ca
To: xen-devel@lists.xensource.com
Cc: anthony.perard@citrix.com, brendan@cs.ubc.ca,
ian.jackson@eu.citrix.com, ian.campbell@citrix.com
Subject: [PATCH 6 of 6 V2] libxl: resume instead of unpause on xl save -c
Date: Tue, 31 Jan 2012 20:38:25 -0800 [thread overview]
Message-ID: <545f88c2bc73b063a5d0.1328071105@athos.nss.cs.ubc.ca> (raw)
In-Reply-To: <patchbomb.1328071099@athos.nss.cs.ubc.ca>
# HG changeset patch
# User Shriram Rajagopalan <rshriram@cs.ubc.ca>
# Date 1328070814 28800
# Node ID 545f88c2bc73b063a5d0e7adbd95baed4d93790f
# Parent 68ca0e9ea59c4c67d3a10ce968cca7aff50184fe
libxl: resume instead of unpause on xl save -c
The guest is "suspended" via libxl_domain_suspend when taking a snapshot.
So call libxl_domain_resume instead of libxl_domain_unpause, when taking
a checkpoint of the domain (using xl save -c).
Signed-off-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>
diff -r 68ca0e9ea59c -r 545f88c2bc73 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c Tue Jan 31 20:33:34 2012 -0800
+++ b/tools/libxl/xl_cmdimpl.c Tue Jan 31 20:33:34 2012 -0800
@@ -2524,7 +2524,7 @@ static int save_domain(const char *p, co
close(fd);
if (checkpoint)
- libxl_domain_unpause(ctx, domid);
+ libxl_domain_resume(ctx, domid, 1);
else
libxl_domain_destroy(ctx, domid);
prev parent reply other threads:[~2012-02-01 4:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 4:38 [PATCH 0 of 6 V2] libxl: refactor suspend/resume code rshriram
2012-02-01 4:38 ` [PATCH 1 of 6 V2] libxl: helper function to send commands to traditional qemu rshriram
2012-02-01 4:38 ` [PATCH 2 of 6 V2] libxl: bugfix: create_domain() return to caller if !daemonize rshriram
2012-02-01 4:38 ` [PATCH 3 of 6 V2] libxl: QMP stop/resume & refactor QEMU suspend/resume/save rshriram
2012-02-01 14:14 ` Stefano Stabellini
2012-02-01 16:59 ` Shriram Rajagopalan
2012-02-01 17:38 ` Stefano Stabellini
2012-02-01 4:38 ` [PATCH 4 of 6 V2] libxl: support suspend_cancel in domain_resume rshriram
2012-02-01 4:38 ` [PATCH 5 of 6 V2] libxl: refactor migrate_domain and generalize migrate_receive rshriram
2012-02-01 4:38 ` rshriram [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545f88c2bc73b063a5d0.1328071105@athos.nss.cs.ubc.ca \
--to=rshriram@cs.ubc.ca \
--cc=anthony.perard@citrix.com \
--cc=brendan@cs.ubc.ca \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).