From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH ARM v8 2/4] mini-os: arm: interrupt controller Date: Fri, 14 Nov 2014 11:48:21 +0000 Message-ID: <5465EC05.8060801@linaro.org> References: <1412328051-20015-1-git-send-email-talex5@gmail.com> <1412328051-20015-3-git-send-email-talex5@gmail.com> <1413889218.23337.24.camel@citrix.com> <20141021215406.GJ3481@type.youpi.perso.aquilenet.fr> <1413968619.20604.56.camel@citrix.com> <5447ABE4.1030703@linaro.org> <544FB580.7080809@linaro.org> <544FBB76.7050102@linaro.org> <5465E89C.1030701@linaro.org> <1415965353.7113.16.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XpFMX-00036b-DO for xen-devel@lists.xenproject.org; Fri, 14 Nov 2014 11:48:25 +0000 Received: by mail-wi0-f170.google.com with SMTP id r20so4844942wiv.5 for ; Fri, 14 Nov 2014 03:48:24 -0800 (PST) In-Reply-To: <1415965353.7113.16.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Thomas Leonard , David Scott , Anil Madhavapeddy , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Samuel Thibault List-Id: xen-devel@lists.xenproject.org On 14/11/2014 11:42, Ian Campbell wrote: > On Fri, 2014-11-14 at 11:33 +0000, Julien Grall wrote: >>>> Though IIRC, mini-os for ARM is not yet SMP. >>> >>> It's difficult to see what needs to be done to support code that >>> doesn't exist yet. For example, would gic_init be called once, or once >>> per processor? Before or after the other processors are started? >> >> Some part of the code maybe necessary: setting PPIs/SGIs... You can give >> a look to Linux/Xen GIC drivers to have an idea on what is necessary. > > This would be necessary as part of the port of mini-os to support SMP. I > don't see why it should be necessary now, going to SMP is surely going > to require a bunch of refactoring in other places too (Xen itself > certainly did). I just answered to his question. I didn't asked for changing this code right now. -- Julien Grall