From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 16/21] xen/passthrough: iommu_deassign_device_dt: By default reassign device to nobody Date: Mon, 12 Jan 2015 16:33:45 +0000 Message-ID: <54B3F769.1090604@linaro.org> References: <1406818852-31856-1-git-send-email-julien.grall@linaro.org> <1406818852-31856-17-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YAhwW-0000RZ-8m for xen-devel@lists.xenproject.org; Mon, 12 Jan 2015 16:34:16 +0000 Received: by mail-wg0-f46.google.com with SMTP id x13so20310084wgg.5 for ; Mon, 12 Jan 2015 08:34:14 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Stefano, Sorry for the very late answer on this patch. On 06/08/14 17:23, Stefano Stabellini wrote: >> diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c >> index 45d4a59..f8affa0 100644 >> --- a/xen/drivers/passthrough/device_tree.c >> +++ b/xen/drivers/passthrough/device_tree.c >> @@ -75,14 +75,12 @@ int iommu_deassign_dt_device(struct domain *d, struct dt_device_node *dev) >> >> spin_lock(&dtdevs_lock); >> >> - rc = hd->platform_ops->reassign_dt_device(d, hardware_domain, dev); >> + rc = hd->platform_ops->reassign_dt_device(d, NULL, dev); >> if ( rc ) >> goto fail; > > At this point, isn't it better just to call arm_smmu_detach_dev? That would mean introducing an new callback in structure. I would prefer modify reassign_dt_device rather than adding a new one. Regards, -- Julien Grall