From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v3 2/3] libxc/xentrace: Replace xc_tbuf_set_cpu_mask with CPU mask with xc_cpumap_t instead of uint32_t Date: Tue, 31 Mar 2015 11:41:16 +0100 Message-ID: <551A79CC.9030302@eu.citrix.com> References: <1427211559-15185-1-git-send-email-konrad.wilk@oracle.com> <1427211559-15185-3-git-send-email-konrad.wilk@oracle.com> <5519755D.9000103@eu.citrix.com> <20150330165411.GC13141@l.oracle.com> <551988E3.4050600@eu.citrix.com> <20150330180450.GA21779@l.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Yctbm-0001vL-Mm for xen-devel@lists.xenproject.org; Tue, 31 Mar 2015 10:41:22 +0000 In-Reply-To: <20150330180450.GA21779@l.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 03/30/2015 07:04 PM, Konrad Rzeszutek Wilk wrote: > > Sorry, not '&&'. Phew. :-) > It was the '(i * 8)' vs '(i*8)' Yeah, as you can probably tell style isn't one of the things I'm very particular about (at least compared with a lot of other developers). I think what you had originally was probably closer in line with what's in xentrace.c. >> So do you want to take this patch and put it into your series (making >> all the changes you suggest), or do you want me to polish it up and send >> it separately? > > I will take it in, do the changes, and also test it on a large machine. > Thought should I wait until you are done looking at the other patch? Sure, I should have that done here shortly. -George