From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [RFC][PATCH 02/13] introduce
	XENMEM_reserved_device_memory_map
Date: Thu, 23 Apr 2015 20:32:00 +0800
Message-ID: <5538E640.10008@intel.com>
References: <1428657724-3498-1-git-send-email-tiejun.chen@intel.com>
	<1428657724-3498-3-git-send-email-tiejun.chen@intel.com>
	<20150416145916.GF13441@deinos.phlegethon.org>
	<552FED140200007800072D70@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <552FED140200007800072D70@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Tim Deegan <tim@xen.org>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, yang.z.zhang@intel.com
List-Id: xen-devel@lists.xenproject.org

  >>> @@ -121,6 +121,8 @@ void iommu_dt_domain_destroy(struct domain *d);
>>>
>>>   struct page_info;
>>>
>>> +typedef int iommu_grdm_t(xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt);
>>
>> This needs a comment describing what the return values are.
>
> Will do.
>


I'm not sure if yourself determine providing this. So here I just 
initial one draft,

/*
  * Get rdm info handling.
  *
  *    return   0: Don't hit rdm. This means either there's no any rdm 
existent,
  *                or there's no any rdm matching requirements.
  *           < 0: Failed.
  *           > 0: Handle to special case.
  *                  1: Hit one rdm entry.
  *                  others: Currently this is never happened.
  */

But if you already have one just please ignore this and tell me

Thanks
Tiejun