From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v5 3/3] xen: block access to IO port 0xcf9 Date: Thu, 07 May 2015 16:22:18 +0100 Message-ID: <554B9F4A0200007800077B7F@mail.emea.novell.com> References: <1431010459-20920-1-git-send-email-roger.pau@citrix.com> <1431010459-20920-4-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YqNcz-000626-QX for xen-devel@lists.xenproject.org; Thu, 07 May 2015 15:22:21 +0000 In-Reply-To: <1431010459-20920-4-git-send-email-roger.pau@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne Cc: Andrew Cooper , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org >>> On 07.05.15 at 16:54, wrote: > This port is used by PM1a and should not be accessed directly by Dom0. I don't think this is unconditionally PM1a - that should be read out of the FADT if at all. I also don't think port CF9 universally serves as the port to do reboots. I.e. I don't think this should be done unconditionally. > This > also premits trapping 2 and 4 byte accesses to 0xcf8, which need to be > handled by the hypervisor. Only 4-byte ones need to be handled in the hypervisor, and you're not adding any code forcing 2-byte ones to be allowed through. I.e. > Also, since admin_io_okay is now a wrapper around ioports_access_permitted > remove it. ... this should not be the final result afaict. Jan