Re: [RFC][PATCH 07/13] xen/passthrough: extend hypercall to support rdm reservation policy

[Julien Grall <julien.grall@citrix.com>]

Hi,

On 11/05/15 09:42, Chen, Tiejun wrote:
> diff --git a/xen/drivers/passthrough/arm/smmu.c
> b/xen/drivers/passthrough/arm/smmu.c
> index 8a9b58b..a3e6383 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -2599,7 +2599,7 @@ static void arm_smmu_destroy_iommu_domain(struct
> iommu_domain *domain)
>  }
> 
>  static int arm_smmu_assign_dev(struct domain *d, u8 devfn,
> -                              struct device *dev)
> +                              struct device *dev, u32 flag)
>  {
>         struct iommu_domain *domain;
>         struct arm_smmu_xen_domain *xen_domain;
> diff --git a/xen/drivers/passthrough/device_tree.c
> b/xen/drivers/passthrough/device_tree.c
> index 377d41d..97e7fc5 100644
> --- a/xen/drivers/passthrough/device_tree.c
> +++ b/xen/drivers/passthrough/device_tree.c
> @@ -41,7 +41,8 @@ int iommu_assign_dt_device(struct domain *d, struct
> dt_device_node *dev)
>      if ( !list_empty(&dev->domain_list) )
>          goto fail;
> 
> -    rc = hd->platform_ops->assign_device(d, 0, dt_to_dev(dev));
> +    rc = hd->platform_ops->assign_device(d, 0, dt_to_dev(dev),
> +                                         XEN_DOMCTL_PCIDEV_RDM_TRY);

On ARM we can passthrough 2 different types of device: PCI device and
platform device described in the device tree (it's a tree representation
of the hardware).

This assign_device callback deals with the latter. So from the name the
value doesn't look right.

Regards,

-- 
Julien Grall