From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org,
ian.jackson@eu.citrix.com, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v9 4/4] libxl: Add interface for querying hypervisor about PCI topology
Date: Fri, 15 May 2015 09:21:34 -0400 [thread overview]
Message-ID: <5555F2DE.3040602@oracle.com> (raw)
In-Reply-To: <20150515084357.GA1405@aepfle.de>
On 05/15/2015 04:43 AM, Olaf Hering wrote:
> On Mon, May 11, Boris Ostrovsky wrote:
>
>> +++ b/tools/libxl/xl_cmdimpl.c
>> @@ -5420,12 +5420,15 @@ static void output_numainfo(void)
>>
>> static void output_topologyinfo(void)
>> + int valid_devs;
>> + valid_devs++;
>> + if (valid_devs == 0)
>
> This is broken as well, merged as e78e8b9bb649bf0f18d940fb12a4f6c55be34915
>
I will send a patch but I am curious whether this broke the build for
you too? Because I didn't get any warnings.
-boris
next prev parent reply other threads:[~2015-05-15 13:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 16:31 [PATCH v9 0/4] Display IO topology when PXM data is available (plus some cleanup) Boris Ostrovsky
2015-05-11 16:31 ` [PATCH v9 1/4] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc Boris Ostrovsky
2015-05-13 15:46 ` Olaf Hering
2015-05-13 15:56 ` Boris Ostrovsky
2015-05-13 16:51 ` Olaf Hering
2015-05-11 16:31 ` [PATCH v9 2/4] libxl/libxc: Move libxl_get_numainfo()'s " Boris Ostrovsky
2015-05-11 16:31 ` [PATCH v9 3/4] libxc: Provide set_xen_guest_handle_offset macro Boris Ostrovsky
2015-05-13 14:56 ` Ian Campbell
2015-05-11 16:31 ` [PATCH v9 4/4] libxl: Add interface for querying hypervisor about PCI topology Boris Ostrovsky
2015-05-15 8:43 ` Olaf Hering
2015-05-15 13:21 ` Boris Ostrovsky [this message]
2015-05-15 13:50 ` Olaf Hering
2015-05-15 14:01 ` Boris Ostrovsky
2015-05-15 14:23 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5555F2DE.3040602@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).