From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v9 4/4] libxl: Add interface for querying
 hypervisor about PCI topology
Date: Fri, 15 May 2015 10:01:04 -0400
Message-ID: <5555FC20.5000507@oracle.com>
References: <1431361890-3466-1-git-send-email-boris.ostrovsky@oracle.com>
	<1431361890-3466-5-git-send-email-boris.ostrovsky@oracle.com>
	<20150515084357.GA1405@aepfle.de> <5555F2DE.3040602@oracle.com>
	<20150515135050.GA23826@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150515135050.GA23826@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 05/15/2015 09:50 AM, Olaf Hering wrote:
> On Fri, May 15, Boris Ostrovsky wrote:
>
>> I will send a patch but I am curious whether this broke the build for you
>> too? Because I didn't get any warnings.
> Builds with -O0, but fails without it.
>

What gcc version are you using?

[root@ovs104 libxl]# grep valid_devs xl_cmdimpl.c
     int valid_devs;
             valid_devs++;
     if (valid_devs == 0)
[root@ovs104 libxl]# gcc -v
Using built-in specs.
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man 
--infodir=/usr/share/info 
--with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap 
--enable-shared --enable-threads=posix --enable-checking=release 
--with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions 
--enable-gnu-unique-object 
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada 
--enable-java-awt=gtk --disable-dssi 
--with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre 
--enable-libgcj-multifile --enable-java-maintainer-mode 
--with-ecj-jar=/usr/share/java/eclipse-ecj.jar 
--disable-libjava-multilib --with-ppl --with-cloog --with-tune=generic 
--with-arch_32=i686 --build=x86_64-redhat-linux
Thread model: posix
gcc version 4.4.7 20120313 (Red Hat 4.4.7-11) (GCC)
[root@ovs104 libxl]# /bin/rm xl_cmdimpl.o
[root@ovs104 libxl]# gcc  -O2 -fomit-frame-pointer -m64 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes 
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-D__XEN_TOOLS__ -MMD -MF .xl_cmdimpl.o.d -D_LARGEFILE_SOURCE 
-D_LARGEFILE64_SOURCE   -Werror -Wno-format-zero-length 
-Wmissing-declarations -Wno-declaration-after-statement 
-Wformat-nonliteral -I. -fPIC -pthread 
-I/root/xen/tools/libxl/../../tools/libxc/include 
-I/root/xen/tools/libxl/../../tools/include 
-I/root/xen/tools/libxl/../../tools/libxl 
-I/root/xen/tools/libxl/../../tools/libxc/include 
-I/root/xen/tools/libxl/../../tools/include 
-I/root/xen/tools/libxl/../../tools/include -Wshadow -include 
/root/xen/tools/libxl/../../tools/config.h   -c -o xl_cmdimpl.o 
xl_cmdimpl.c
[root@ovs104 libxl]# ls -l xl_cmdimpl.o
-rw-r--r--. 1 root root 258912 May 15 10:02 xl_cmdimpl.o
[root@ovs104 libxl]#