From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v2 02/41] arm/acpi: Build pmstat for x86 only
Date: Mon, 18 May 2015 13:54:53 +0100
Message-ID: <5559E11D.3040008@citrix.com>
References: <1431893048-5214-1-git-send-email-parth.dixit@linaro.org>
	<1431893048-5214-3-git-send-email-parth.dixit@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1431893048-5214-3-git-send-email-parth.dixit@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Parth Dixit <parth.dixit@linaro.org>, xen-devel@lists.xen.org
Cc: keir@xen.org, ian.campbell@citrix.com, andrew.cooper3@citrix.com, tim@xen.org, julien.grall@citrix.com, stefano.stabellini@citrix.com, jbeulich@suse.com, christoffer.dall@linaro.org
List-Id: xen-devel@lists.xenproject.org

Hi Parth,

On 17/05/15 21:03, Parth Dixit wrote:
> Pmstat is currently not supported for arm in xen.
> Configure and build pmstat for x86 architecture only.
> 
> Signed-off-by: Parth Dixit <parth.dixit@linaro.org>
> ---
>  xen/common/sysctl.c       | 2 ++
>  xen/drivers/acpi/Makefile | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
> index 601dd09..96d06cf 100644
> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> @@ -170,6 +170,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
>          op->u.availheap.avail_bytes <<= PAGE_SHIFT;
>          break;
>  
> +#ifdef CONFIG_X86

pmstat seems to be tight with cpufreq, so I would use HAS_CPUFREQ.

>  #ifdef HAS_ACPI

And combine the two #ifdef.

>      case XEN_SYSCTL_get_pmstat:
>          ret = do_get_pm_info(&op->u.get_pmstat);
> @@ -181,6 +182,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
>              copyback = 1;
>          break;
>  #endif
> +#endif
>  
>      case XEN_SYSCTL_page_offline_op:
>      {
> diff --git a/xen/drivers/acpi/Makefile b/xen/drivers/acpi/Makefile
> index 7294b5a..009fe5a 100644
> --- a/xen/drivers/acpi/Makefile
> +++ b/xen/drivers/acpi/Makefile
> @@ -5,7 +5,7 @@ subdir-$(x86) += apei
>  obj-bin-y += tables.init.o
>  obj-$(x86) += numa.o
>  obj-y += osl.o
> -obj-y += pmstat.o
> +obj-$(x86) += pmstat.o

obj-$(HAS_CPUFREQ)

>  
>  obj-$(x86) += hwregs.o
>  obj-$(x86) += reboot.o
> 

Regards,

-- 
Julien Grall