From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [RFC][v2][PATCH 10/14] tools: extend XENMEM_set_memory_map Date: Mon, 25 May 2015 10:00:09 +0800 Message-ID: <55628229.8020907@intel.com> References: <1432287314-4388-1-git-send-email-tiejun.chen@intel.com> <1432287314-4388-11-git-send-email-tiejun.chen@intel.com> <555F0402.9080803@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <555F0402.9080803@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , JBeulich@suse.com, tim@xen.org, konrad.wilk@oracle.com, andrew.cooper3@citrix.com, kevin.tian@intel.com, yang.z.zhang@intel.com, ian.campbell@citrix.com, wei.liu2@citrix.com, Ian.Jackson@eu.citrix.com, stefano.stabellini@citrix.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 2015/5/22 18:25, Julien Grall wrote: > Hi, > > On 22/05/2015 10:35, Tiejun Chen wrote: >> Here we'll construct a basic guest e820 table via >> XENMEM_set_memory_map. This table includes lowmem, highmem >> and RDMs if they exist. And hvmloader would need this info >> later. >> >> Signed-off-by: Tiejun Chen >> --- >> tools/libxl/libxl_dom.c | 87 >> +++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 87 insertions(+) >> >> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c >> index 84d5465..cc4b1a6 100644 >> --- a/tools/libxl/libxl_dom.c >> +++ b/tools/libxl/libxl_dom.c >> @@ -913,6 +913,87 @@ out: >> return rc; >> } >> >> +/* >> + * Here we're just trying to set these kinds of e820 mappings: >> + * >> + * #1. Low memory region >> + * >> + * Low RAM starts at least from 1M to make sure all standard regions >> + * of the PC memory map, like BIOS, VGA memory-mapped I/O and vgabios, >> + * have enough space. >> + * Note: Those stuffs below 1M are still constructed with multiple >> + * e820 entries by hvmloader. At this point we don't change anything. >> + * >> + * #2. RDM region if it exists >> + * >> + * #3. High memory region if it exists >> + * >> + * Note: these regions are not overlapping since we already check >> + * to adjust them. Please refer to libxl__domain_device_construct_rdm(). >> + */ >> +#define GUEST_LOW_MEM_START_DEFAULT 0x100000 >> +static int libxl__domain_construct_memmap(libxl__gc *gc, >> + libxl_domain_config *d_config, >> + uint32_t domid, >> + struct xc_hvm_build_args >> *args) > > The code within this function is x86 specific. Shouldn't it be moved in > libxl_x86.c? > Sounds reasonable. Thanks Tiejun