From: "Jan Beulich" <JBeulich@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Xen Devel <xen-devel@lists.xen.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH RFC] hotplug/Linux: Add --wait to iptables calls.
Date: Mon, 01 Jun 2015 16:08:50 +0100 [thread overview]
Message-ID: <556C91A2020000780007FCEE@mail.emea.novell.com> (raw)
In-Reply-To: <1433170772-17684-1-git-send-email-anthony.perard@citrix.com>
>>> On 01.06.15 at 16:59, <anthony.perard@citrix.com> wrote:
> --- a/tools/hotplug/Linux/vif-common.sh
> +++ b/tools/hotplug/Linux/vif-common.sh
> @@ -130,9 +130,9 @@ frob_iptable()
> local c="-D"
> fi
>
> - iptables "$c" FORWARD -m physdev --physdev-is-bridged --physdev-in "$dev" \
> + iptables --wait "$c" FORWARD -m physdev --physdev-is-bridged --physdev-in "$dev" \
> "$@" -j ACCEPT 2>/dev/null &&
> - iptables "$c" FORWARD -m physdev --physdev-is-bridged --physdev-out "$dev" \
> + iptables --wait "$c" FORWARD -m physdev --physdev-is-bridged --physdev-out "$dev" \
> -j ACCEPT 2>/dev/null
>
> if [ \( "$command" == "online" -o "$command" == "add" \) -a $? -ne 0 ]
Looking at my oldest system's "iptables --help" I can't spot such an
option (which doesn't necessarily mean it's not supported). Did you
make sure all (older) distros we care about actually support this?
Jan
next prev parent reply other threads:[~2015-06-01 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 14:59 [PATCH RFC] hotplug/Linux: Add --wait to iptables calls Anthony PERARD
2015-06-01 15:08 ` Jan Beulich [this message]
2015-06-01 15:17 ` Ian Campbell
2015-06-01 16:09 ` Anthony PERARD
2015-06-01 16:13 ` Wei Liu
2015-06-01 16:15 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C91A2020000780007FCEE@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=anthony.perard@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).