From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH v1 3/5] tools/libxl: move remus codes into
 libxl_remus.c
Date: Wed, 3 Jun 2015 00:13:12 +0800
Message-ID: <556DD618.6040103@cn.fujitsu.com>
References: <1432116090-19486-1-git-send-email-yanghy@cn.fujitsu.com>	
	<1432116090-19486-4-git-send-email-yanghy@cn.fujitsu.com>
	<1433256409.15036.294.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1433256409.15036.294.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca
List-Id: xen-devel@lists.xenproject.org



On 06/02/2015 10:46 PM, Ian Campbell wrote:
> On Wed, 2015-05-20 at 18:01 +0800, Yang Hongyang wrote:
>> move remus codes into libxl_remus.c
>
> "code"
>
> Apart from dropping some "static" and adding some prototypes to the
> header this is purely motion, correct? (I assume this about the last one
> too).

and add remus setup and teardown func. that's all.

>> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
>> index b2eeb89..c3d70eb 100644
>> --- a/tools/libxl/libxl_internal.h
>> +++ b/tools/libxl/libxl_internal.h
>> @@ -2815,6 +2815,7 @@ _hidden void libxl__remus_devices_commit(libxl__egc *egc,
>>                                            libxl__remus_devices_state *rds);
>>   _hidden int libxl__netbuffer_enabled(libxl__gc *gc);
>>
>> +
>
> Please avoid spurious whitespace changes.

fixed.

>
>>   /*----- Domain suspend (save) state structure -----*/
>>
>>   typedef struct libxl__domain_suspend_state libxl__domain_suspend_state;
>> @@ -3197,6 +3198,16 @@ void libxl__domain_suspend_callback(void *data);
>>   void libxl__domain_suspend(libxl__egc *egc,
>>                              libxl__domain_suspend_state *dss);
>>
>> +/* Remus callbacks for save */
>> +void libxl__remus_domain_suspend_callback(void *data);
>> +void libxl__remus_domain_resume_callback(void *data);
>> +void libxl__remus_domain_checkpoint_callback(void *data);
>> +/* Remus setup and teardown*/
>> +void libxl__remus_setup(libxl__egc *egc, libxl__domain_save_state *dss);
>> +void libxl__remus_teardown(libxl__egc *egc,
>> +                           libxl__domain_save_state *dss,
>> +                           int rc);
>
> Please mark these all _hidden.

ok.

>
>
> .
>

-- 
Thanks,
Yang.