From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: gic-hip04: Resync the driver with the GICv2 Date: Wed, 10 Jun 2015 14:23:09 -0400 Message-ID: <5578808D.1080502@citrix.com> References: <1430938350-23985-1-git-send-email-julien.grall@citrix.com> <554B27D9.6020104@linaro.org> <1430991151.2660.343.camel@citrix.com> <554B5C71.3020007@linaro.org> <55566052.1000500@citrix.com> <5559EAD3.7030000@linaro.org> <556C3E4D.1080304@citrix.com> <556C4133.6060703@linaro.org> <556C4BE1.9090508@citrix.com> <556C5B8F.4070405@linaro.org> <556C7BA1.4030406@citrix.com> <5FC3163CFD30C246ABAA99954A238FA82C7AA3@lhreml504-mbs> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z2kei-0002iQ-0j for xen-devel@lists.xenproject.org; Wed, 10 Jun 2015 18:23:16 +0000 In-Reply-To: <5FC3163CFD30C246ABAA99954A238FA82C7AA3@lhreml504-mbs> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Shameerali Kolothum Thodi , Julien Grall , Zoltan Kiss , Ian Campbell Cc: "xen-devel@lists.xenproject.org" , "tim@xen.org" , "stefano.stabellini@citrix.com" , Zoltan Kiss List-Id: xen-devel@lists.xenproject.org On 09/06/2015 09:03, Shameerali Kolothum Thodi wrote: > Hi Julien/Zoli, Hi Shameer, >> http://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=shortlog;h=refs/heads/for-huawei/gicv2-on-gicv3 > I had a run of this staging on our D01 board. Thank you for testing. > Xen fails to boot with below error: > (XEN) domain 0: vGIC requested is not supported > (XEN) CPU0: Unexpected Trap: Data Abort > > After going through the code, it looks to me that hip04 gicv2_info is missing the vgic_versions initialisation. Made the following changes and xen booted and started dom0. > > --- ../xen-org/arch/arm/gic-hip04.c 2015-06-01 16:33:40.000000000 +0100 > +++ ./xen/arch/arm/gic-hip04.c 2015-06-09 13:21:44.355012016 +0100 > @@ -735,6 +735,7 @@ static int __init hip04gic_preinit(struc > const void *data) > { > gicv2_info.hw_version = GIC_V2; > + gicv2_info.vgic_versions = GIC_V2; > gicv2_info.node = node; > register_gic_ops(&hip04gic_ops); > dt_irq_xlate = gic_irq_xlate; > > (Sorry, this is a diff not a proper git patch) > Please correct me, if this is not the correct way to init the vgic_versions. This is correct. Although, I'm planning to rework the way that the GIC tells the supported vGIC in the next version of this GICv2 on GICv3 series. Regards, -- Julien Grall