From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Hongyang Subject: Re: [PATCH v6 COLO 12/15] COLO nic: implement COLO nic subkind Date: Mon, 15 Jun 2015 10:13:41 +0800 Message-ID: <557E34D5.3000608@cn.fujitsu.com> References: <1433735159-26739-1-git-send-email-yanghy@cn.fujitsu.com> <1433735159-26739-13-git-send-email-yanghy@cn.fujitsu.com> <20150612143549.GT14606@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150612143549.GT14606@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.campbell@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 06/12/2015 10:35 PM, Wei Liu wrote: > On Mon, Jun 08, 2015 at 11:45:56AM +0800, Yang Hongyang wrote: >> implement COLO nic subkind. >> >> Signed-off-by: Yang Hongyang >> Signed-off-by: Wen Congyang >> --- >> tools/hotplug/Linux/Makefile | 1 + >> tools/hotplug/Linux/colo-proxy-setup | 131 +++++++++++++++ > > There are hardcoded paths in this script. Please avoid that. > > For one Debian has iptables under /sbin, not /usr/local/sbin. We are using a modified iptables here. But hardcode is not a good thing, will avoid this in the next version. > > Wei. > . > -- Thanks, Yang.