From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [RFC PATCH v3 03/18] xen: console: Add ratelimit
 support for error message
Date: Thu, 25 Jun 2015 14:21:54 +0100
Message-ID: <558C0072.90406@citrix.com>
References: <1434974517-12136-1-git-send-email-vijay.kilari@gmail.com>
	<1434974517-12136-4-git-send-email-vijay.kilari@gmail.com>
	<558827EA0200007800087945@mail.emea.novell.com>
	<CALicx6vQWgcZJ8pxDWvAyd8SSoPWY=EWot75yJOLhJ6jtTg2xg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6vQWgcZJ8pxDWvAyd8SSoPWY=EWot75yJOLhJ6jtTg2xg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>, Jan Beulich <JBeulich@suse.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, manish.jaggi@caviumnetworks.com, Tim Deegan <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Julien Grall <julien.grall@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
List-Id: xen-devel@lists.xenproject.org

On 25/06/15 14:14, Vijay Kilari wrote:
> On Mon, Jun 22, 2015 at 6:51 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 22.06.15 at 14:01, <vijay.kilari@gmail.com> wrote:
>>> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>>>
>>> XENLOG_ERR_RATE_LIMIT and XENLOG_G_ERR_RATE_LIMIT
>>> log levels are added to support rate limit for error messages
>> If you mean to say that rate limiting currently doesn't work for
>> XENLOG_ERR messages, then that's a problem to be fixed by
>> adjusting existing code, not by adding yet another log level.
> For GUEST messages  ERR and WARN are rate limited by
> setting lower threshold to 0 and upper threshold to 2 as below
>
> #define XENLOG_GUEST_UPPER_THRESHOLD 2 /* Do not print INFO and DEBUG  */
> #define XENLOG_GUEST_LOWER_THRESHOLD 0 /* Rate-limit ERR and WARNING   */
>
> So do you recommend to set same threshold levels to Xen messages
> there by ERR & WARN are rate limited?

Xen already has guest rate limiting logic, which has separate visible
and ratelimited boundaries.

http://xenbits.xen.org/docs/unstable/misc/xen-command-line.html

Look at guest_loglvl.

If the existing logic isn't working then it should be fixed.  We should
not introduce a second way of doing this.

~Andrew