* [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc
@ 2015-06-26 15:43 Julien Grall
2015-06-26 15:54 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Julien Grall @ 2015-06-26 15:43 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, stefano.stabellini, ian.campbell
This field have been set but not used since Xen 4.5. Slim down Xen by
about 4K by removing it.
Also fix comment coding style.
Signed-off-by: Julien Grall <julien.grall@citrix.com>
---
xen/arch/arm/irq.c | 7 ++++---
xen/include/asm-arm/irq.h | 1 -
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
index 2dd43ee..6bb076e 100644
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -219,10 +219,11 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq)
desc->handler->end(desc);
set_bit(_IRQ_INPROGRESS, &desc->status);
- desc->arch.eoi_cpu = smp_processor_id();
- /* the irq cannot be a PPI, we only support delivery of SPIs to
- * guests */
+ /*
+ * The irq cannot be a PPI, we only support delivery of SPIs to
+ * guests.
+ */
vgic_vcpu_inject_spi(info->d, info->virq);
goto out_no_end;
}
diff --git a/xen/include/asm-arm/irq.h b/xen/include/asm-arm/irq.h
index 34b492b..6c00d09 100644
--- a/xen/include/asm-arm/irq.h
+++ b/xen/include/asm-arm/irq.h
@@ -15,7 +15,6 @@ struct arch_pirq
};
struct arch_irq_desc {
- int eoi_cpu;
unsigned int type;
};
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc
2015-06-26 15:43 [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc Julien Grall
@ 2015-06-26 15:54 ` Ian Campbell
2015-06-26 15:57 ` Julien Grall
2015-07-03 15:34 ` Ian Campbell
0 siblings, 2 replies; 6+ messages in thread
From: Ian Campbell @ 2015-06-26 15:54 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, stefano.stabellini
On Fri, 2015-06-26 at 16:43 +0100, Julien Grall wrote:
> This field have been set but not used since Xen 4.5. Slim down Xen by
> about 4K by removing it.
>
> Also fix comment coding style.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> ---
> xen/arch/arm/irq.c | 7 ++++---
> xen/include/asm-arm/irq.h | 1 -
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
> index 2dd43ee..6bb076e 100644
> --- a/xen/arch/arm/irq.c
> +++ b/xen/arch/arm/irq.c
> @@ -219,10 +219,11 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq)
> desc->handler->end(desc);
>
> set_bit(_IRQ_INPROGRESS, &desc->status);
> - desc->arch.eoi_cpu = smp_processor_id();
>
> - /* the irq cannot be a PPI, we only support delivery of SPIs to
> - * guests */
> + /*
> + * The irq cannot be a PPI, we only support delivery of SPIs to
> + * guests.
Stray tab?
Otherwise LGTM: Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc
2015-06-26 15:54 ` Ian Campbell
@ 2015-06-26 15:57 ` Julien Grall
2015-06-26 16:04 ` Ian Campbell
2015-07-03 15:34 ` Ian Campbell
1 sibling, 1 reply; 6+ messages in thread
From: Julien Grall @ 2015-06-26 15:57 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, stefano.stabellini
Hi Ian,
On 26/06/2015 17:54, Ian Campbell wrote:
> On Fri, 2015-06-26 at 16:43 +0100, Julien Grall wrote:
>> This field have been set but not used since Xen 4.5. Slim down Xen by
>> about 4K by removing it.
>>
>> Also fix comment coding style.
>>
>> Signed-off-by: Julien Grall <julien.grall@citrix.com>
>> ---
>> xen/arch/arm/irq.c | 7 ++++---
>> xen/include/asm-arm/irq.h | 1 -
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
>> index 2dd43ee..6bb076e 100644
>> --- a/xen/arch/arm/irq.c
>> +++ b/xen/arch/arm/irq.c
>> @@ -219,10 +219,11 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq)
>> desc->handler->end(desc);
>>
>> set_bit(_IRQ_INPROGRESS, &desc->status);
>> - desc->arch.eoi_cpu = smp_processor_id();
>>
>> - /* the irq cannot be a PPI, we only support delivery of SPIs to
>> - * guests */
>> + /*
>> + * The irq cannot be a PPI, we only support delivery of SPIs to
>> + * guests.
>
> Stray tab?
Yes, sorry. I have edited the file with the wrong vim configuration.
> Otherwise LGTM: Acked-by: Ian Campbell <ian.campbell@citrix.com>
Shall I resend the patch?
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc
2015-06-26 15:57 ` Julien Grall
@ 2015-06-26 16:04 ` Ian Campbell
2015-06-26 18:15 ` Julien Grall
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2015-06-26 16:04 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, stefano.stabellini
On Fri, 2015-06-26 at 17:57 +0200, Julien Grall wrote:
> Hi Ian,
>
> On 26/06/2015 17:54, Ian Campbell wrote:
> > On Fri, 2015-06-26 at 16:43 +0100, Julien Grall wrote:
> >> This field have been set but not used since Xen 4.5. Slim down Xen by
> >> about 4K by removing it.
> >>
> >> Also fix comment coding style.
> >>
> >> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> >> ---
> >> xen/arch/arm/irq.c | 7 ++++---
> >> xen/include/asm-arm/irq.h | 1 -
> >> 2 files changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
> >> index 2dd43ee..6bb076e 100644
> >> --- a/xen/arch/arm/irq.c
> >> +++ b/xen/arch/arm/irq.c
> >> @@ -219,10 +219,11 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq)
> >> desc->handler->end(desc);
> >>
> >> set_bit(_IRQ_INPROGRESS, &desc->status);
> >> - desc->arch.eoi_cpu = smp_processor_id();
> >>
> >> - /* the irq cannot be a PPI, we only support delivery of SPIs to
> >> - * guests */
> >> + /*
> >> + * The irq cannot be a PPI, we only support delivery of SPIs to
> >> + * guests.
> >
> > Stray tab?
>
> Yes, sorry. I have edited the file with the wrong vim configuration.
>
> > Otherwise LGTM: Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Shall I resend the patch?
I'll fix on commit I think
>
> Regards,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc
2015-06-26 16:04 ` Ian Campbell
@ 2015-06-26 18:15 ` Julien Grall
0 siblings, 0 replies; 6+ messages in thread
From: Julien Grall @ 2015-06-26 18:15 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, stefano.stabellini
On 26/06/2015 18:04, Ian Campbell wrote:
> On Fri, 2015-06-26 at 17:57 +0200, Julien Grall wrote:
>> Hi Ian,
>>
>> On 26/06/2015 17:54, Ian Campbell wrote:
>>> On Fri, 2015-06-26 at 16:43 +0100, Julien Grall wrote:
>>>> This field have been set but not used since Xen 4.5. Slim down Xen by
>>>> about 4K by removing it.
>>>>
>>>> Also fix comment coding style.
>>>>
>>>> Signed-off-by: Julien Grall <julien.grall@citrix.com>
>>>> ---
>>>> xen/arch/arm/irq.c | 7 ++++---
>>>> xen/include/asm-arm/irq.h | 1 -
>>>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
>>>> index 2dd43ee..6bb076e 100644
>>>> --- a/xen/arch/arm/irq.c
>>>> +++ b/xen/arch/arm/irq.c
>>>> @@ -219,10 +219,11 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq)
>>>> desc->handler->end(desc);
>>>>
>>>> set_bit(_IRQ_INPROGRESS, &desc->status);
>>>> - desc->arch.eoi_cpu = smp_processor_id();
>>>>
>>>> - /* the irq cannot be a PPI, we only support delivery of SPIs to
>>>> - * guests */
>>>> + /*
>>>> + * The irq cannot be a PPI, we only support delivery of SPIs to
>>>> + * guests.
>>>
>>> Stray tab?
>>
>> Yes, sorry. I have edited the file with the wrong vim configuration.
>>
>>> Otherwise LGTM: Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>
>> Shall I resend the patch?
>
> I'll fix on commit I think
Thank you!
--
Julien Grall
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc
2015-06-26 15:54 ` Ian Campbell
2015-06-26 15:57 ` Julien Grall
@ 2015-07-03 15:34 ` Ian Campbell
1 sibling, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2015-07-03 15:34 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, stefano.stabellini
On Fri, 2015-06-26 at 16:54 +0100, Ian Campbell wrote:
> On Fri, 2015-06-26 at 16:43 +0100, Julien Grall wrote:
> > This field have been set but not used since Xen 4.5. Slim down Xen by
> > about 4K by removing it.
> >
> > Also fix comment coding style.
> >
> > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> > ---
> > xen/arch/arm/irq.c | 7 ++++---
> > xen/include/asm-arm/irq.h | 1 -
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
> > index 2dd43ee..6bb076e 100644
> > --- a/xen/arch/arm/irq.c
> > +++ b/xen/arch/arm/irq.c
> > @@ -219,10 +219,11 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq)
> > desc->handler->end(desc);
> >
> > set_bit(_IRQ_INPROGRESS, &desc->status);
> > - desc->arch.eoi_cpu = smp_processor_id();
> >
> > - /* the irq cannot be a PPI, we only support delivery of SPIs to
> > - * guests */
> > + /*
> > + * The irq cannot be a PPI, we only support delivery of SPIs to
> > + * guests.
>
> Stray tab?
>
> Otherwise LGTM: Acked-by: Ian Campbell <ian.campbell@citrix.com>
Applied.
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-03 15:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-26 15:43 [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc Julien Grall
2015-06-26 15:54 ` Ian Campbell
2015-06-26 15:57 ` Julien Grall
2015-06-26 16:04 ` Ian Campbell
2015-06-26 18:15 ` Julien Grall
2015-07-03 15:34 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).