From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc Date: Fri, 26 Jun 2015 20:15:33 +0200 Message-ID: <558D96C5.70100@citrix.com> References: <1435333389-3694-1-git-send-email-julien.grall@citrix.com> <1435334051.32500.202.camel@citrix.com> <558D7667.7030600@citrix.com> <1435334640.32500.203.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z8YAf-0006FU-Pm for xen-devel@lists.xenproject.org; Fri, 26 Jun 2015 18:16:13 +0000 In-Reply-To: <1435334640.32500.203.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 26/06/2015 18:04, Ian Campbell wrote: > On Fri, 2015-06-26 at 17:57 +0200, Julien Grall wrote: >> Hi Ian, >> >> On 26/06/2015 17:54, Ian Campbell wrote: >>> On Fri, 2015-06-26 at 16:43 +0100, Julien Grall wrote: >>>> This field have been set but not used since Xen 4.5. Slim down Xen by >>>> about 4K by removing it. >>>> >>>> Also fix comment coding style. >>>> >>>> Signed-off-by: Julien Grall >>>> --- >>>> xen/arch/arm/irq.c | 7 ++++--- >>>> xen/include/asm-arm/irq.h | 1 - >>>> 2 files changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c >>>> index 2dd43ee..6bb076e 100644 >>>> --- a/xen/arch/arm/irq.c >>>> +++ b/xen/arch/arm/irq.c >>>> @@ -219,10 +219,11 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq) >>>> desc->handler->end(desc); >>>> >>>> set_bit(_IRQ_INPROGRESS, &desc->status); >>>> - desc->arch.eoi_cpu = smp_processor_id(); >>>> >>>> - /* the irq cannot be a PPI, we only support delivery of SPIs to >>>> - * guests */ >>>> + /* >>>> + * The irq cannot be a PPI, we only support delivery of SPIs to >>>> + * guests. >>> >>> Stray tab? >> >> Yes, sorry. I have edited the file with the wrong vim configuration. >> >>> Otherwise LGTM: Acked-by: Ian Campbell >> >> Shall I resend the patch? > > I'll fix on commit I think Thank you! -- Julien Grall