From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Hongyang Subject: Re: [PATCH v3 COLOPre 09/26] tools/libxl: introduce enum type libxl_checkpointed_stream Date: Tue, 30 Jun 2015 17:53:49 +0800 Message-ID: <5592672D.4080703@cn.fujitsu.com> References: <1435213552-10556-1-git-send-email-yanghy@cn.fujitsu.com> <1435213552-10556-10-git-send-email-yanghy@cn.fujitsu.com> <1435595439.32500.384.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435595439.32500.384.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 06/30/2015 12:30 AM, Ian Campbell wrote: > On Thu, 2015-06-25 at 14:25 +0800, Yang Hongyang wrote: >> introduce enum type libxl_checkpointed_stream in IDL. >> rename the last argument of migrate_receive from "remus" to >> "checkpointed" since the semantics of this parameter has >> changed. > > I don't see anything here which is hitting the libxl API layer, it all > looks to be internal to xl. Is that going to change in a future patch > i.e. is something in libxl.h going to now accept a > libxl_checkpointed_stream? It is stored in restore_params.checkpointed_stream, does this a libxl API layer structure? > > If this is completely internal to xl you should just make an enum there > I think (you could add xl_types.idl, but that seems like overkill) > > Ian. > > . > -- Thanks, Yang.