From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v5 05/16] x86/hvm: unify internal portio and
 mmio intercepts
Date: Thu, 2 Jul 2015 17:12:09 +0200
Message-ID: <559554C9.1080402@citrix.com>
References: <1435669558-5421-1-git-send-email-paul.durrant@citrix.com>
	<1435669558-5421-6-git-send-email-paul.durrant@citrix.com>
	<55955014.8090609@citrix.com>
	<9AAE0902D5BC7E449B7C8E4E778ABCD02597928F@AMSPEX01CL02.citrite.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=618139c40=roger.pau@citrix.com>)
	id 1ZAg9v-0001lg-3M
	for xen-devel@lists.xenproject.org; Thu, 02 Jul 2015 15:12:15 +0000
In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD02597928F@AMSPEX01CL02.citrite.net>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Paul Durrant <Paul.Durrant@citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>, "Keir (Xen.org)" <keir@xen.org>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

El 02/07/15 a les 17.02, Paul Durrant ha escrit:
>> -----Original Message-----
>> From: Roger Pau Monn=E9 [mailto:roger.pau@citrix.com]
>> Sent: 02 July 2015 15:52
>> To: Paul Durrant; xen-devel@lists.xenproject.org
>> Cc: Andrew Cooper; Keir (Xen.org); Jan Beulich
>> Subject: Re: [Xen-devel] [PATCH v5 05/16] x86/hvm: unify internal portio=
 and
>> mmio intercepts
>>
>> El 30/06/15 a les 15.05, Paul Durrant ha escrit:
>> [...]
>> +void msixtbl_init(struct domain *d)
>>> +{
>>> +    register_mmio_handler(d, &msixtbl_mmio_ops);
>>
>> Since you are adding an initialization function to vmsi I think
>> msixtbl_list and msixtbl_list_lock should also be initialized here
>> instead of hvm_domain_initialise.
>>
> =

> Yes, that sounds quite reasonable. Perhaps as a follow-up patch though, u=
nless I need to post v6 of the series for some other reason.

That's fine, if not I can also add it as a pre-patch to my HVMlite
stuff, it's trivial.

Roger.