From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v5 08/16] x86/hvm: unify stdvga mmio
 intercept with standard mmio intercept
Date: Thu, 2 Jul 2015 17:55:36 +0100
Message-ID: <55956D08.9010600@citrix.com>
References: <1435669558-5421-1-git-send-email-paul.durrant@citrix.com>
	<1435669558-5421-9-git-send-email-paul.durrant@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=61810cf3e=Andrew.Cooper3@citrix.com>)
	id 1ZAhmS-0003Hw-6s
	for xen-devel@lists.xenproject.org; Thu, 02 Jul 2015 16:56:08 +0000
In-Reply-To: <1435669558-5421-9-git-send-email-paul.durrant@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Paul Durrant <paul.durrant@citrix.com>, xen-devel@lists.xenproject.org
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 30/06/15 14:05, Paul Durrant wrote:
> @@ -275,7 +275,8 @@ static uint8_t stdvga_mem_readb(uint64_t addr)
>      return ret;
>  }
>  
> -static uint64_t stdvga_mem_read(uint64_t addr, uint64_t size)
> +static int stdvga_mem_read(const struct hvm_io_handler *handler,
> +                           uint64_t addr, uint32_t size, uint64_t *p_data)
>  {
>      uint64_t data = 0;

This initialiser wants to default to ~0ULL.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>