From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH v2] libxl: Make local_initiate_attach more rational Date: Thu, 2 Jul 2015 19:55:09 +0200 Message-ID: <55957AFD.6020903@citrix.com> References: <1435858969-20728-1-git-send-email-george.dunlap@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1435858969-20728-1-git-send-email-george.dunlap@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap , xen-devel@lists.xen.org Cc: Ian Jackson , Wei Liu , Ian Campbell List-Id: xen-devel@lists.xenproject.org El 02/07/15 a les 19.42, George Dunlap ha escrit: > There are a lot of paths through > libxl__device_disk_local_initiate_attach(), but they all really boil > down to one thing: Can we just access the file directly, or do we need > to attach it? > = > The requirements for direct access are fairly simple: > * Is this local (as opposed to a driver domain)? > * Is this a raw format (as opposed to cooked)? > * Does this have no scripts associated with it? > = > If it meets all those requirements, we can access it directly; > otherwise we need to attach it. > = > This fixes a bug where bootloader execution fails for disks with > hotplug scripts. > = > This should fix a theoretical bug when using a qdisk backend in a > driver domain. (Not tested.) > = > Based on a patch by Roger Pau Monne . > = > Signed-off-by: George Dunlap LGTM Acked-by: Roger Pau Monn=E9