From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH v2 12/22] elfnotes: intorduce a new
 PHYS_ENTRY elfnote
Date: Fri, 3 Jul 2015 12:52:58 +0200
Message-ID: <5596698A.1070100@citrix.com>
References: <1435761975-98579-1-git-send-email-roger.pau@citrix.com>
	<1435761975-98579-13-git-send-email-roger.pau@citrix.com>
	<55966595.7040309@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=619f38fea=roger.pau@citrix.com>)
	id 1ZAyaf-0007uC-06
	for xen-devel@lists.xenproject.org; Fri, 03 Jul 2015 10:53:05 +0000
In-Reply-To: <55966595.7040309@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 03/07/15 a les 12.36, David Vrabel ha escrit:
> On 01/07/15 15:46, Roger Pau Monne wrote:
>> This new elfnote contains the 32bit entry point into the kernel. Xen will
>> use this entry point in order to launch the guest kernel in 32bit protected
>> mode with paging disabled.
> [...]
>> --- a/tools/xcutils/readnotes.c
>> +++ b/tools/xcutils/readnotes.c
>> @@ -159,6 +159,9 @@ static unsigned print_notes(struct elf_binary *elf, ELF_HANDLE_DECL(elf_note) st
>>  		case XEN_ELFNOTE_L1_MFN_VALID:
>>  			print_l1_mfn_valid_note("L1_MFN_VALID", elf , note);
>>  			break;
>> +		case XEN_ELFNOTE_PHYS_ENTRY:
>> +			print_numeric_note("PHYS_ENTRY", elf , note);
>> +			break;
> 
> I assume this is supposed to be XEN_ELFNOTE_PHYS32_ENTRY?  It doesn't
> build otherwise.

Yes, I've realized about this error yesterday. Not sure why I didn't
catch it my test build, I think NFS was playing dirty tricks behind me...

Anyway, I will send an updated version today with this fixed.

Roger.