From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v5 11/16] x86/hvm: split I/O completion handling from state model Date: Fri, 3 Jul 2015 16:08:42 +0100 Message-ID: <5596A57A.3000106@citrix.com> References: <1435669558-5421-1-git-send-email-paul.durrant@citrix.com> <1435669558-5421-12-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZB2a7-0006My-Ur for xen-devel@lists.xenproject.org; Fri, 03 Jul 2015 15:08:48 +0000 In-Reply-To: <1435669558-5421-12-git-send-email-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paul Durrant , xen-devel@lists.xenproject.org Cc: Keir Fraser , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 30/06/15 14:05, Paul Durrant wrote: > diff --git a/xen/include/asm-x86/hvm/vcpu.h b/xen/include/asm-x86/hvm/vcpu.h > index 2ed0606..efb373f 100644 > --- a/xen/include/asm-x86/hvm/vcpu.h > +++ b/xen/include/asm-x86/hvm/vcpu.h > @@ -34,11 +34,16 @@ enum hvm_io_state { > HVMIO_none = 0, > HVMIO_dispatched, > HVMIO_awaiting_completion, > - HVMIO_handle_mmio_awaiting_completion, > - HVMIO_handle_pio_awaiting_completion, > HVMIO_completed > }; > > +enum hvm_io_completion { > + HVMIO_no_completion = 0, No need to default to 0 here. Otherwise, Reviewed-by: Andrew Cooper