From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v6 6/6] xen: arm: consolidate mmio and irq mapping to dom0 Date: Mon, 6 Jul 2015 12:02:55 +0100 Message-ID: <559A605F.8060002@citrix.com> References: <1435938959.9447.171.camel@citrix.com> <1435938972-18288-6-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435938972-18288-6-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 03/07/15 16:56, Ian Campbell wrote: > The code in the callbacks for dt_for_each_irq_map and > dt_for_each_range is very similar to the code in handle_device for > each non-pci device. > > In fact the only major difference is that the irq callback needs to > call irq_set_spi_type in the PCI case. Refactor into a > map_dt_irq_to_domain callback which does the irq_set_spi_type and then > calls map_irq_to_domain which is also used from handle_device. > > For mmio map_range_to_domain can already be used directly from > handle_device too. > > Signed-off-by: Ian Campbell Reviewed-by: Julien Grall Regards, -- Julien Grall