From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [RFC PATCH v3 17/18] xen/arm: ITS: Generate ITS
 node for Dom0
Date: Tue, 7 Jul 2015 09:21:53 +0100
Message-ID: <559B8C21.4030506@citrix.com>
References: <1434974517-12136-1-git-send-email-vijay.kilari@gmail.com>
	<1434974517-12136-18-git-send-email-vijay.kilari@gmail.com>
	<1435583179.32500.324.camel@citrix.com>
	<CALicx6vwYp+0MK3FFZgEox19oLHDGx5-vno3EcO-QJKE5OamLA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6vwYp+0MK3FFZgEox19oLHDGx5-vno3EcO-QJKE5OamLA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>, Ian Campbell <ian.campbell@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, Tim Deegan <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

Hi,

On 07/07/2015 06:31, Vijay Kilari wrote:
> On Mon, Jun 29, 2015 at 6:36 PM, Ian Campbell <ian.campbell@citrix.com> wrote:
>> On Mon, 2015-06-22 at 17:31 +0530, vijay.kilari@gmail.com wrote:
>
>>>
>>> +int its_make_dt_node(const struct domain *d,
>>> +                     const struct dt_device_node *node, void *fdt)
>>> +{
>>> +    struct its_node *its;
>>> +    const struct dt_device_node *gic;
>>> +    const void *compatible = NULL;
>>> +    u32 len;
>>> +    __be32 *new_cells, *tmp;
>>> +    int res = 0;
>>> +
>>> +    /* Will pass only first ITS node info */
>>> +    /* TODO: Handle multi node */
>>> +    its = list_first_entry(&its_nodes, struct its_node, entry);
>>
>> I think this should be done at the top level by not walking all children
>> and by blacklisting all ITS nodes to be replaced by our own.
>
>     I have added TODO for multinode.
> For now, I plan to support only single ITS node. I don't have
> platform support right now to test multinode

I'm not sure to understand what you want to support multi-node here...

This function is used to create the ITS node for DOM0. From the design 
document, guest domain only sees a single node.

Blacklisted ITS node in the top level function is just one line (you 
have to give the compatible string)>

Regards,

-- 
Julien Grall