From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: elena.ufimtseva@oracle.com, tim@xen.org, wei.liu2@citrix.com,
ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com,
andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, roger.pau@citrix.com
Subject: Re: [PATCH v2 3/4] x86/pvh: Handle hypercalls for 32b PVH guests
Date: Tue, 07 Jul 2015 11:54:48 -0400 [thread overview]
Message-ID: <559BF648.8040605@oracle.com> (raw)
In-Reply-To: <559BB5F1020000780008D3C0@mail.emea.novell.com>
On 07/07/2015 05:20 AM, Jan Beulich wrote:
>>>> On 29.06.15 at 22:21, <boris.ostrovsky@oracle.com> wrote:
>> @@ -4929,6 +4928,27 @@ static hvm_hypercall_t *const pvh_hypercall64_table[NR_hypercalls] = {
>> [ __HYPERVISOR_arch_1 ] = (hvm_hypercall_t *)paging_domctl_continuation
>> };
>>
>> +extern void compat_mmuext_op(void); /* XXX: need proper declaration */
> No XXX like this please. Just add a suitable declaration. And in fact
> adding it here (with correct arguments, and without the comment)
> would seem quite fine to me.
The XXX here was meant for eliciting comments from reviewers ;-)
-boris
next prev parent reply other threads:[~2015-07-07 15:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 20:21 [PATCH v2 0/4] 32-bit domU PVH support Boris Ostrovsky
2015-06-29 20:21 ` [PATCH v2 1/4] x86/compat: Test whether guest has 32b shinfo instead of being a PV 32b domain Boris Ostrovsky
2015-07-07 9:11 ` Jan Beulich
2015-07-07 15:46 ` Boris Ostrovsky
2015-07-07 16:15 ` Jan Beulich
2015-07-07 17:13 ` Boris Ostrovsky
2015-07-08 6:48 ` Jan Beulich
2015-07-08 13:59 ` Boris Ostrovsky
2015-07-08 14:08 ` Jan Beulich
2015-07-08 14:40 ` Boris Ostrovsky
2015-07-08 14:50 ` Jan Beulich
2015-07-08 20:57 ` Boris Ostrovsky
2015-07-09 7:02 ` Jan Beulich
2015-07-09 14:10 ` Boris Ostrovsky
2015-07-09 14:17 ` Jan Beulich
2015-07-09 14:30 ` Boris Ostrovsky
2015-07-09 16:05 ` Boris Ostrovsky
2015-07-09 16:15 ` Jan Beulich
2015-06-29 20:21 ` [PATCH v2 2/4] x86/pvh: Set 32b PVH guest mode in XEN_DOMCTL_set_address_size Boris Ostrovsky
2015-07-07 9:15 ` Jan Beulich
2015-07-07 15:53 ` Boris Ostrovsky
2015-07-07 16:16 ` Jan Beulich
2015-06-29 20:21 ` [PATCH v2 3/4] x86/pvh: Handle hypercalls for 32b PVH guests Boris Ostrovsky
2015-07-07 9:20 ` Jan Beulich
2015-07-07 15:54 ` Boris Ostrovsky [this message]
2015-06-29 20:21 ` [PATCH v2 4/4] libxc/x86/pvh: Allow creation of " Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559BF648.8040605@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=elena.ufimtseva@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).