Re: [PATCH v2 2/4] x86/pvh: Set 32b PVH guest mode in XEN_DOMCTL_set_address_size

["Jan Beulich" <JBeulich@suse.com>]

>>> On 07.07.15 at 17:53, <boris.ostrovsky@oracle.com> wrote:
> On 07/07/2015 05:15 AM, Jan Beulich wrote:
>>>>> On 29.06.15 at 22:21, <boris.ostrovsky@oracle.com> wrote:
>>> @@ -6491,6 +6490,20 @@ enum hvm_intblk nhvm_interrupt_blocked(struct vcpu *v)
>>>       return hvm_funcs.nhvm_intr_blocked(v);
>>>   }
>>>   
>>> +int hvm_set_mode(struct vcpu *v, int mode)
>>> +{
>>> +    if ( mode == 4 )
>>> +    {
>>> +        v->arch.hvm_vcpu.guest_efer &= ~(EFER_LMA | EFER_LME);
>>> +        hvm_update_guest_efer(v);
>>> +    }
>>> +
>>> +    if ( hvm_funcs.set_mode )
>>> +        return hvm_funcs.set_mode(v, mode);
>>> +
>>> +    return 0;
>>> +}
>> -EOPNOTSUPP?
> 
> Why do you think this should be an error? I probably will need to update 
> this to handle mode==8 for calls from switch_native() as you pointed out 
> above but in general it seems to me it should be OK if this procedure 
> doesn't do anything. Below too.

Because the function then didn't do what it was asked for.

Jan