From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v5][PATCH 01/16] xen: introduce
	XENMEM_reserved_device_memory_map
Date: Wed, 08 Jul 2015 05:32:09 +0800
Message-ID: <559C4559.8000406@intel.com>
References: <1436249837-14747-1-git-send-email-tiejun.chen@intel.com>
	<1436249837-14747-2-git-send-email-tiejun.chen@intel.com>
	<21915.46421.168214.462484@mariner.uk.xensource.com>
	<559BE649020000780008D701@mail.emea.novell.com>
	<21915.53969.742635.129344@mariner.uk.xensource.com>
	<559BF8B6020000780008D840@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <559BF8B6020000780008D840@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Yang Zhang <yang.z.zhang@intel.com>, Kevin Tian <kevin.tian@intel.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

>>>>> +    /* IN/OUT */
>>>>> +    unsigned int    nr_entries;
>>>>
>>>> Perhaps I am missing something but I can't find any API documentation
>>>> for the return value and error returns from this new hypercall.
>>>
>>> I think this is in line with everything else in this header - am I
>>> overlooking something?
>>
>> In particular, wouldn't it be sensible to write down that if the
>> number of entries available is bigger than nr_entries, the hypercall
>> fails with ERANGE, sets nr_entries to the real number of entries, and
>> leaves the buffer in an undefined state ?
>
> I can add a sentence to that effect.
>

Jan,

Please deliver your final patch to me and then I can resend that next.

Thanks
Tiejun