From: Julien Grall <julien.grall@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
Sander Eikelenboom <linux@eikelenboom.it>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] x86/MSI: fix guest unmasking when handling IRQ via event channel
Date: Wed, 8 Jul 2015 10:07:24 +0100 [thread overview]
Message-ID: <559CE84C.8050500@citrix.com> (raw)
In-Reply-To: <559D01DE020000780008E03C@mail.emea.novell.com>
Hi,
On 08/07/2015 09:56, Jan Beulich wrote:
> --- a/xen/include/asm-arm/irq.h
> +++ b/xen/include/asm-arm/irq.h
> @@ -47,6 +47,8 @@ int release_guest_irq(struct domain *d,
>
> void arch_move_irqs(struct vcpu *v);
>
> +#define arch_evtchn_bind_pirq(d, pirq) ((void)((d) + (pirq)))
> +
This addition is here in order to ensure that d and pirq are evaluated,
right?
If so, I didn't find it obvious to understand. Why didn't you use a
static inline? Or maybe add a comment explicitly say this is not
implemented.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-07-08 9:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 8:56 [PATCH] x86/MSI: fix guest unmasking when handling IRQ via event channel Jan Beulich
2015-07-08 9:03 ` Andrew Cooper
2015-07-08 9:07 ` Julien Grall [this message]
2015-07-08 10:55 ` Jan Beulich
2015-07-08 11:02 ` Julien Grall
2015-07-08 9:39 ` David Vrabel
2015-07-08 10:58 ` Jan Beulich
2015-07-08 11:14 ` David Vrabel
2015-07-08 12:33 ` Jan Beulich
2015-07-10 10:29 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559CE84C.8050500@citrix.com \
--to=julien.grall@citrix.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=linux@eikelenboom.it \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).