From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Chao Peng <chao.p.peng@linux.intel.com>, xen-devel@lists.xen.org
Cc: dario.faggioli@citrix.com, keir@xen.org,
boris.ostrovsky@oracle.com, JBeulich@suse.com
Subject: Re: [PATCH v3] x86: correct socket_cpumask allocation
Date: Thu, 9 Jul 2015 16:16:43 +0100 [thread overview]
Message-ID: <559E905B.1070503@citrix.com> (raw)
In-Reply-To: <1436451837-26171-1-git-send-email-chao.p.peng@linux.intel.com>
On 09/07/15 15:23, Chao Peng wrote:
> For booting cpu, the socket number is not needed to be 0 so
> it needs to be computed by cpu number.
>
> For secondary cpu, phys_proc_id is not valid in CPU_PREPARE
> notifier(cpu_smpboot_alloc), so cpu_to_socket(cpu) can't be used.
> Instead, pre-allocate secondary_cpu_mask in cpu_smpboot_alloc()
> and later consume it in smp_store_cpu_info().
>
> This patch also change socket_cpumask type from 'cpumask_var_t *'
> to 'cpumask_t **' so that smaller NR_CPUS works.
>
> Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Tested-by: Dario Faggioli <dario.faggioli@citrix.com>
> Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
The v2 of this path seems to be holding up fine against the XenServer
test pool. No failures to boot encountered so far.
Tested-by: Andrew Cooper <andrew.cooper3@citrix.com>
As the differences between v2 and v3 appear largely mechanical and not
functional in nature, this Tested-by can probably still stand.
~Andrew
next prev parent reply other threads:[~2015-07-09 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 14:23 [PATCH v3] x86: correct socket_cpumask allocation Chao Peng
2015-07-09 15:16 ` Andrew Cooper [this message]
2015-07-09 15:36 ` Boris Ostrovsky
2015-07-10 14:29 ` Dario Faggioli
2015-07-10 14:47 ` Andrew Cooper
2015-07-10 14:57 ` Dario Faggioli
2015-07-10 15:13 ` Jan Beulich
2015-07-10 15:25 ` Jan Beulich
2015-07-10 16:03 ` Dario Faggioli
2015-07-13 3:19 ` Chao Peng
2015-07-10 15:33 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559E905B.1070503@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=chao.p.peng@linux.intel.com \
--cc=dario.faggioli@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).